New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 5.3 error in JHtmlContent #22877

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
6 participants
@SharkyKZ
Contributor

SharkyKZ commented Oct 30, 2018

Pull Request for Issue #22876.

Summary of Changes

Fixes a syntax error on PHP 5.3.

Testing Instructions

Test on PHP 5.3 setup.
Create Category List menu item.
Set Filter Field to Month (published).
View menu item in frontend.

Expected result

Select with months shown.

Actual result

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /libraries/cms/html/content.php on line 74

Documentation Changes Required

No.

@alikon

This comment has been minimized.

Contributor

alikon commented Oct 30, 2018

I have tested this item successfully on c6f865a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22877.

@npostman

This comment has been minimized.

Contributor

npostman commented Oct 31, 2018

Experienced the same issue on PHP 5.3 (I know I need to update...). Fix in pull request worked for me too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22877.

@SharkyKZ

This comment has been minimized.

Contributor

SharkyKZ commented Oct 31, 2018

@npostman please submit your test:

Login to issue tracker: https://issues.joomla.org/tracker/joomla-cms/22877.
Click Test this.
Mark Tested successfully if test was successful.
Click Submit test result.

@npostman

This comment has been minimized.

Contributor

npostman commented Oct 31, 2018

I have tested this item successfully on c6f865a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22877.

@Quy

This comment has been minimized.

Contributor

Quy commented Oct 31, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22877.

@joomla-cms-bot joomla-cms-bot added the RTC label Oct 31, 2018

@mbabker mbabker added this to the Joomla 3.9.1 milestone Nov 1, 2018

@mbabker mbabker merged commit a2a630a into joomla:staging Nov 1, 2018

5 checks passed

Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Nov 1, 2018

@SharkyKZ SharkyKZ deleted the SharkyKZ:php53 branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment