New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9.1] Automatic title at Latest Actions Backend Module #22925

Merged
merged 4 commits into from Nov 5, 2018

Conversation

Projects
None yet
8 participants
@zero-24
Contributor

zero-24 commented Nov 2, 2018

Pull Request for Issue #22921

Summary of Changes

Fix the automatic title option at the Latest Actions Backend Module

Testing Instructions

Go to Extensions > Modules > Administrator > Latest Actions > Advanced > Automatic Title (ON).
Next go to System > Control panel.

Expected result

Just an updated title: Last %s Actions (where %s is replaced by the count of actions to show)

Actual result

error

Documentation Changes Required

none

@zero-24 zero-24 requested a review from brianteeman as a code owner Nov 2, 2018

@zero-24 zero-24 referenced this pull request Nov 2, 2018

Closed

Latest Actions #22921

@zero-24 zero-24 added this to the Joomla 3.9.1 milestone Nov 2, 2018

@brianteeman

string is ok

@Quy

This comment has been minimized.

Contributor

Quy commented Nov 3, 2018

Does it matter if the strings are different Last 5 Actions vs Latest Actions?

@zero-24

This comment has been minimized.

Contributor

zero-24 commented Nov 3, 2018

Does it matter if the strings are different Last 5 Actions vs Latest Actions?

I don't get the question?As is the intend to change the title ;) Or do you mean en-GB wise?

@alikon

This comment has been minimized.

Contributor

alikon commented Nov 3, 2018

I have tested this item successfully on 7d03e0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

1 similar comment
@jsubri

This comment has been minimized.

Contributor

jsubri commented Nov 3, 2018

I have tested this item successfully on 7d03e0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

@infograf768

This comment has been minimized.

Member

infograf768 commented Nov 3, 2018

Please add strings.
return JText::plural('MOD_LATESTACTIONS_TITLE', $params->get('count', 5));
when using JText::plural we expect multiple language strings.

Example
return JText::plural('MOD_LOGGED_TITLE', $params->get('count', 5));

Strings

MOD_LOGGED_TITLE="Last Logged-in Users"
MOD_LOGGED_TITLE_1="Last Logged-in User"
MOD_LOGGED_TITLE_MORE="Last %s Logged-in Users"
@@ -8,4 +8,7 @@ MOD_LATESTACTIONS_FIELD_COUNT_LABEL="Count"
MOD_LATESTACTIONS_FIELD_COUNT_DESC="The number of items to display (default 5)."
MOD_LATESTACTIONS_LAYOUT_DEFAULT="Default"
MOD_LATEST_ACTIONS_NO_MATCHING_RESULTS="No Matching Results"
MOD_LATESTACTIONS_TITLE="Last Action"

This comment has been minimized.

@infograf768

infograf768 Nov 4, 2018

Member

This should be plural
Last Actions

@infograf768

This comment has been minimized.

Member

infograf768 commented Nov 5, 2018

I have tested this item successfully on 9ae1124


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.9.1 milestone Nov 5, 2018

@infograf768

This comment has been minimized.

Member

infograf768 commented Nov 5, 2018

As the last changes only concerned lang strings, no need for further tests.

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 5, 2018

@mbabker mbabker added this to the Joomla 3.9.1 milestone Nov 5, 2018

@mbabker mbabker merged commit c3e5837 into joomla:staging Nov 5, 2018

3 of 4 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Nov 5, 2018

@zero-24 zero-24 deleted the zero-24:latestactions_automatic_title branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment