Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Fix navigating to the first page in pagination when SEF is off #23042

Merged
merged 1 commit into from Nov 17, 2018

Conversation

Projects
None yet
5 participants
@csthomas
Copy link
Contributor

commented Nov 11, 2018

Pull Request for Issue #22983

Summary of Changes

Reverted a few lines added in the previous PR #19467
Changed the unit test method JPaginationTest::buildLink($url) to better emulate Router::build($url), where empty parameters such as &limitstart= are always removed from the URL.

Testing Instructions

Test #22983 when SEF is ON and OFF.

Expected result

You can back to the first page in pagination when SEF is OFF.

Actual result

When SEF is OFF the limitstart parameter remains in the link to the first page and you can not back to the first page.

Documentation Changes Required

No

@hendrikbehncke

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

Test successful on 3f30b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

I have tested this item successfully on 3f30b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 13, 2018

@mbabker mbabker added this to the Joomla 3.9.1 milestone Nov 17, 2018

@mbabker mbabker merged commit 30ab125 into joomla:staging Nov 17, 2018

3 of 4 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csthomas csthomas deleted the csthomas:fix_nonsef_limitstart branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.