New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actionlogs] Remove limitations on the logDeletePeriod #23084

Merged
merged 1 commit into from Nov 17, 2018

Conversation

Projects
None yet
5 participants
@PhilETaylor
Contributor

PhilETaylor commented Nov 15, 2018

This removes the arbitrary limit of 30 days, and the step of 5 day implements for the logDeletePeriod in plg_actionlogs

The reason behind this, is that its impossible to select a period like 1 year (365 days) or quarterly or anything greater than 30 days...

We should leave it up to the Joomla Admin to choose his period. (Although I dread to think how much will be collected in 365 days, but as the default is NEVER to delete (0) the logs, then this obviously is not Joomla's issue)

Quickly PR'ed in GitHub, Not tested.

Before PR:
screenshot 2018-11-15 at 07 34 39

After PR you should be able to select any number of days.

@Quy

This comment has been minimized.

Contributor

Quy commented Nov 15, 2018

I have tested this item successfully on 6767880


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23084.

1 similar comment
@alikon

This comment has been minimized.

Contributor

alikon commented Nov 16, 2018

I have tested this item successfully on 6767880


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23084.

@PhilETaylor

This comment has been minimized.

Contributor

PhilETaylor commented Nov 16, 2018

RTC then?

@Quy

This comment has been minimized.

Contributor

Quy commented Nov 16, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23084.

@joomla-cms-bot joomla-cms-bot added RTC and removed PR-staging labels Nov 16, 2018

@mbabker mbabker added this to the Joomla 3.9.1 milestone Nov 17, 2018

@mbabker mbabker merged commit a5732ee into joomla:staging Nov 17, 2018

3 of 4 checks passed

continuous-integration/drone/pr the build failed
Details
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment