Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: adapting display of Joomla versions plus some #23107

Merged
merged 7 commits into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@infograf768
Copy link
Member

commented Nov 18, 2018

Pull Request for Issue #21024 (comment)

Summary of Changes

As it was decided to allow Joomla updates to beta branches, the Joomla verions in RTL may now contain some latin characters.
The version should subsequently be displayed as LTR.

As I was at it, I also corrected the admin stats module display and the Maximum upload size MB figure.

Testing Instructions

In JoomlaUpdate Options choose Custom URL and add this link :
https://update.joomla.org/core/nightlies/next_major_list.xml
It will present the 4.0.0-alpha6-dev update
Save Options.
Install the Persian language.
Publish the mod_admin_stats module (Statistics) in cpanel position

With English as default admin language:

Display CPanel in one browser window and Joomlaupdate in another window (switch tabs there)

Make Persian as default admin language.
Reload the browser windows.

Apply patch and test again.

Before patch

joomlaupdatequickicons_before

siteinfobefore

joomlaupdate_before_1

joomlaupdate_before_2

After patch

joomlaupdatequickicons_after

siteinfo_after

joomlaupdate_after_1

joomlaupdate_after_2

@mbabker @rdeutz

@franz-wohlkoenig franz-wohlkoenig added J3 Issue and removed J3 Issue labels Apr 5, 2019

@franz-wohlkoenig franz-wohlkoenig changed the title [3.x] RTL: adapting display of Joomla versions plus some RTL: adapting display of Joomla versions plus some Apr 19, 2019

@infograf768 infograf768 requested a review from wilsonge as a code owner Apr 19, 2019

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

i see only at second and third Screenshot Differences between "Before" and "After" Patch. What are the Differences in first and fourth?

@infograf768

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

@franz-wohlkoenig
Not sure which screenshots you are referring to.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

the Screenshots in #23107 (comment)

@infograf768

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

I thought it was clear, sorry.

Instead of alpha6-dev-4.0.0,dev-3.9.1, MB 32.00
we now have correctly in RTL
4.0.0-alpha6-dev, 3.9.1-dev, 32.00 MB

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

I have tested this item successfully on 1ea122b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23107.

infograf768 added some commits Apr 25, 2019

@alikon

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

I have tested this item successfully on 3ea6168


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23107.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 27, 2019

@infograf768 infograf768 added this to the Joomla 3.9.7 milestone Apr 27, 2019

@HLeithner HLeithner merged commit 6af8343 into joomla:staging Jun 4, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC label Jun 4, 2019

@infograf768 infograf768 deleted the infograf768:3.x-jversion branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.