New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX 3.9.1] Add column alias com_banners Clients (Published state broken) #23193

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
7 participants
@JoomliC
Copy link
Contributor

JoomliC commented Nov 28, 2018

Pull Request for Issue with com_banners Clients published state broken in 3.9.1
Related to PR #22851

Summary of Changes

  • Add column alias

Testing Instructions

  • Test to change published state for one or multiple Clients with button and checkbox.
  • Apply this PR and test again.

Expected result

  • Published state is changed
    capture d ecran 2018-11-28 a 17 16 29

Actual result

  • No effect
    capture d ecran 2018-11-28 a 17 16 59
@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Nov 28, 2018

I have tested this item successfully on 9092012


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23193.

@laoneo

This comment has been minimized.

Copy link
Member

laoneo commented Nov 29, 2018

Before testing this one, better to wait for a decision made in #23197.

@SharkyKZ

This comment has been minimized.

Copy link
Contributor

SharkyKZ commented Nov 30, 2018

@laoneo this needs to be merged regardless of whether #22851 is reverted or not.

@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Nov 30, 2018

I have tested this item successfully on 9092012


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23193.

@infograf768 infograf768 removed the PR-staging label Nov 30, 2018

@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Nov 30, 2018

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23193.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 30, 2018

@mbabker mbabker added this to the Joomla 3.9.2 milestone Dec 1, 2018

@mbabker mbabker merged commit cb7dd15 into joomla:staging Dec 1, 2018

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment