Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user session on mssql server and a new $db->quoteBinary() method #23213

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@csthomas
Copy link
Contributor

commented Nov 30, 2018

Summary of Changes

From J3.9 the type of session_id column is varbinary(192) and it works OK for mysql and PostgreSQL database.

In the case of mssql, this column requires explicitly cast to binary value to work properly.

See https://docs.microsoft.com/en-us/sql/t-sql/data-types/data-type-conversion-database-engine?view=sql-server-2017

Testing Instructions

Test user session, login. logout, action logs, etc.

Probably no one will test it on mssql server, please test it at least on mysql.

Expected result

Joomla works (after installing or updating) on the mssql server.

Actual result

Joomla does not work (after installing or updating) on the mssql server.

Documentation Changes Required

Yes.
A new method $db->quoteBinary($data).

Tomasz Narloch
@alikon

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

Probably no one will test it on mssql server, please test it at least on mysql.

🤦‍♂

on postgresql only 😄

@alikon

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

shouldn't be ported on https://github.com/joomla-framework/database too ?

@alikon

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

I have tested this item successfully on 958f312


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.

@csthomas

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2018

shouldn't be ported on https://github.com/joomla-framework/database too ?

Yes. I will do it, I start here.

@csthomas

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

I'm closing it for now

@csthomas csthomas closed this Dec 21, 2018
@SharkyKZ

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@csthomas Can you re-open this please?

@HLeithner

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

I have tested this item successfully on 958f312

Works on mssql server 2017 (Linux)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.

@alikon

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 15, 2019
@HLeithner HLeithner removed the RTC label Jul 17, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

I see only one test on an unkown database (alikon) and my test on mssql so we need one for mysql and one for pgsql before this is RTC.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 17, 2019
@franz-wohlkoenig franz-wohlkoenig removed the RTC label Jul 17, 2019
@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Status back on Pending.

@alikon

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

my test was on postgresql

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Status "Ready To Commit" as Test by @alikon was on postgresql.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 20, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

So we need at least one on mysql

@HLeithner HLeithner removed the RTC label Jul 20, 2019
@SharkyKZ

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

Is MariaDB OK?

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 20, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

@SharkyKZ

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

10.1.40 and 10.3.16.

@HLeithner

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

A mysql 5.5 test would be great...

@HLeithner

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Thanks for adding binary encoding support to Joomla.

@HLeithner HLeithner merged commit 7d8b1b8 into joomla:staging Sep 17, 2019
4 checks passed
4 checks passed
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Sep 17, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC label Sep 17, 2019
@csthomas csthomas deleted the csthomas:quoteBinary branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.