New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notices in debug plugin #23240

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
5 participants
@Hackwar
Copy link
Member

Hackwar commented Dec 7, 2018

I've messed around a bit and ran into a bunch of issues in the debug plugin. Simply said, I didn't create any $marks in my script and thus got 2 notices about division by zero. And the $bars/$barsMem vars are not initialised. Not much more that I can say...

@mbabker

mbabker approved these changes Dec 7, 2018

@Hackwar

This comment has been minimized.

Copy link
Member Author

Hackwar commented Dec 7, 2018

Next thing to look at would be, why the debug plugin runs all that code even though debug mode is disabled...

csthomas and others added some commits Dec 18, 2018

Update plugins/system/debug/debug.php
Co-Authored-By: Hackwar <info@joomlager.de>
Update plugins/system/debug/debug.php
Co-Authored-By: Hackwar <info@joomlager.de>
@csthomas

This comment has been minimized.

Copy link
Contributor

csthomas commented Dec 18, 2018

I have tested this item successfully on 8be40a6

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23240.

@rdeutz rdeutz merged commit a6d8d57 into joomla:staging Dec 18, 2018

3 of 4 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rdeutz rdeutz added this to the Joomla 3.9.2 milestone Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment