Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Group action buttons for banner clients #23368

Merged
merged 12 commits into from Jan 7, 2019

Conversation

Projects
None yet
5 participants
@chmst
Copy link
Contributor

chmst commented Dec 28, 2018

Summary of Changes

Group buttons for status changes in a dropdown, see also #22832

Testing Instructions

Apply patch, mark one or more items in the list and perform status changes. Status changes must work as before.

bannerclients

@@ -84,37 +85,85 @@ public function display($tpl = null)
protected function addToolbar()
{
$canDo = ContentHelper::getActions('com_banners');

This comment has been minimized.

@Quy

Quy Dec 28, 2018

Contributor

Remove tabs on lines 88 & 91.

->icon('fa fa-globe')
->buttonClass('btn btn-info')
->listCheck(true);

This comment has been minimized.

@Quy

Quy Dec 28, 2018

Contributor

Remove tabs.

chmst added some commits Dec 28, 2018

@chmst chmst changed the title Group toolbar buttons for banner clients [4.0] Group action buttons for banner clients Dec 28, 2018

@Hackwar

This comment has been minimized.

Copy link
Member

Hackwar commented Dec 30, 2018

I have tested this item successfully on d81b870

Tested this successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23368.

chmst and others added some commits Jan 2, 2019

@wilsonge wilsonge merged commit b2565ce into joomla:4.0-dev Jan 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.