Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layouts to plg_system_privacyconsent #23660

Merged
merged 7 commits into from Feb 19, 2019

Conversation

Projects
None yet
8 participants
@Ruud68
Copy link
Contributor

Ruud68 commented Jan 24, 2019

Pull Request for Issue # n/a.

Summary of Changes

the layouts for plg_system_privacyconsent (label and privacynote) are hardcoded into the field and cannot be overwritten by a template override
This PR adds layouts for both the label and for the privacynote (message). these layouts can be overwritten via template overrides.

Testing Instructions

  1. enable the privacyconsent system plugin
  2. set a joomla article as privacy article in the plugin
    on the front-end user registration page the privacyconsent box should show

Apply this PR

[test] on the front-end user regsitration page the privacyconsent box should be exactly the same as without this PR.

  1. create a template override via the template (e.g. protostar):
    -> tab Create Overrides
    -> column Layouts
    -> select plugins > system (new!)

Edit the created override file: ./templates/protostar/html/layouts/plugins/system/privacyconsent/message.php
4. change the class from alert-info to alert-warning

[Result 1] refresh on the front-end the new user registration form

Edit the created override file: ./templates/protostar/html/layouts/plugins/system/privacyconsent/label.php
5. change <span class="star">&#160;*</span></label> to <span class="star">&copy;*</span></label>

[Result 2] refresh on the front-end the new user registration form

New result

image

Actual result

Make sure that after applying the PR everything works as before.

Documentation Changes Required

$label .= ' data-placement="left"';
}
//~ $privacyArticle = $this->element['article'] > 0 ? (int) $this->element['article'] : 0;

This comment has been minimized.

@Quy

Quy Jan 24, 2019

Contributor

Remove comment

This comment has been minimized.

@Ruud68

Ruud68 Jan 25, 2019

Author Contributor

Thanks @Quy !

Quy and others added some commits Jan 25, 2019

Update plugins/system/privacyconsent/field/privacy.php
Good one :)

Co-Authored-By: Ruud68 <info@onlinecommunityhub.nl>
@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Jan 27, 2019

I have tested this item successfully on 2c75abd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.

@Ruud68

This comment has been minimized.

Copy link
Contributor Author

Ruud68 commented Jan 27, 2019

Thanks for testing @viocassel

@wilsonge

This comment has been minimized.

Copy link
Contributor

wilsonge commented Feb 3, 2019

Please fix the file permissions on the privacy field

@Ruud68

This comment has been minimized.

Copy link
Contributor Author

Ruud68 commented Feb 3, 2019

@wilsonge thanks, not sure where that happened... anyway: fixed :)
Once this PR is approved I will also do the same for the user terms plugin (same 'issue', same solution)

@tecpromotion

This comment has been minimized.

Copy link
Contributor

tecpromotion commented Feb 6, 2019

I have tested this item successfully on fa7b390

I have tested this item successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.

@tecpromotion

This comment has been minimized.

Copy link
Contributor

tecpromotion commented Feb 6, 2019

@wilsonge thanks, not sure where that happened... anyway: fixed :)
Once this PR is approved I will also do the same for the user terms plugin (same 'issue', same solution)

That sounds really great when all the privacy suite codes are overwritable. Thank you @Ruud68

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Feb 6, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 6, 2019

@Ruud68

This comment has been minimized.

Copy link
Contributor Author

Ruud68 commented Feb 7, 2019

@Ruud68

This comment has been minimized.

Copy link
Contributor Author

Ruud68 commented Feb 8, 2019

@Quy please remove RTC as this needs retesting

@HLeithner HLeithner removed the RTC label Feb 8, 2019

@tecpromotion

This comment has been minimized.

Copy link
Contributor

tecpromotion commented Feb 18, 2019

I have tested this item successfully on f0491e4

I have tested this item successfully on 3.9.3.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 18, 2019

@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Feb 18, 2019

I have tested this item successfully on f0491e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.

@HLeithner HLeithner merged commit 777b082 into joomla:staging Feb 19, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Feb 19, 2019

thx

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Feb 19, 2019

@joomla-cms-bot joomla-cms-bot removed the RTC label Feb 19, 2019

@Ruud68 Ruud68 deleted the Ruud68:privacyconsentlayouts branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.