Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] Follow up on #23604 Custom modules editor field #23741

Merged
merged 6 commits into from Feb 25, 2019

Conversation

Projects
None yet
5 participants
@infograf768
Copy link
Member

infograf768 commented Feb 2, 2019

Pull Request for Issue #23604 (comment)

Summary of Changes

After that discussion and merge of #23604 @HLeithner and I thought that we may have the wrong code since 1.5 (see discussion above) concerning the way to get an editor field in Custom modules or similar using < customContent /> in their manifest.

This patch also simplifies the custom type module edit in frontend as we now check the xml, thus normalizing the code vs backend.

Testing Instructions

Install mod_customadv.zip

Create or edit a custom module and the module above in back-end and frontend to confirm the editor field displays.

@HLeithner

Pinging also @johanjanssens (see discussion) as the original code comes from 1.5 and, before merging this, it would be important to know if there was a reason for it or if it was just a typo that made gently its way until now...

@infograf768 infograf768 changed the title [staging] Follow up on #23604 [staging] Follow up on #23604 Custom modules editor field Feb 2, 2019

cs
@infograf768

This comment has been minimized.

Copy link
Member Author

infograf768 commented Feb 3, 2019

@HLeithner
done

infograf768 added some commits Feb 24, 2019

@bembelimen

This comment has been minimized.

Copy link
Contributor

bembelimen commented Feb 24, 2019

I have tested this item successfully on 3e88d2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.

1 similar comment
@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Feb 25, 2019

I have tested this item successfully on 3e88d2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Feb 25, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 25, 2019

@HLeithner HLeithner merged commit 8e1a58c into joomla:staging Feb 25, 2019

0 of 3 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Feb 25, 2019

thx

@joomla-cms-bot joomla-cms-bot removed the RTC label Feb 25, 2019

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.