Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove com_admin profile #24064

Merged
merged 4 commits into from Mar 4, 2019

Conversation

Projects
None yet
4 participants
@brianteeman
Copy link
Contributor

commented Mar 2, 2019

The users icon in the mod_status module links to a view of the logged in users profile. However because it is NOT using com_users any plugins that extend com_users are not displayed. For example TFA plugins when enabled are not accessible from this link and are only accessible from the users component. Maintaining this additional view makes no sense to me. Its a regular cause of bug reports etc.

This PR completely removes the com_admin profile and replaces the link in the module to use com_users. Now any plugins that extend com_users are accessible from the link which is what the user expects

brianteeman added some commits Mar 2, 2019

[4.0] Remove com_admin profile
The users icon in the mod_status module links to a view of the logged in users profile. However because it is NOT using com_users any plugins that extend com_users are not displayed. For example TFA plugins when enabled are not accessible from this link and are only accessible from the users component. Maintaining this additional view makes no sense to me. Its a regular cause of bug reports etc.

This PR completely removes the com_admin profile and replaces the link in the module to use com_users. Now any plugins that extend com_users are accessible from the link which is what the user expects
@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

Makes sense to me - are we aware why this view existed in the past?

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

I honestly dont know. I just know we "didnt remove it" because of b/c

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

Found it - and not sure you are going to believe the reason

https://developer.joomla.org/joomlacode-archive/issue-23347.html

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

BTW any idea why rips is failing all the time

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

No :( @zero-24 @SniperSister can you have a look please

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

updated branch that let rips run again as this seams to be an issue fixed some time ago.

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

thanks @zero-24

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 4, 2019

@wilsonge wilsonge merged commit ea9b47d into joomla:4.0-dev Mar 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Thanks!

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Thanks

@brianteeman brianteeman deleted the brianteeman:userprofile branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.