Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Tinymce 5.0 migration #24110

Merged
merged 65 commits into from Apr 18, 2019
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
0d0e5b9
First update try
bembelimen Mar 3, 2019
9571631
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into tinymce-5.0
bembelimen Mar 6, 2019
8bfa347
More TinyMCE changes
bembelimen Mar 6, 2019
76367f5
Update skin paths
bembelimen Mar 7, 2019
f6b3678
Fix broken height of editor
bembelimen Mar 7, 2019
9750aa9
Offer px instead of pt in font-size dropdown
bembelimen Mar 7, 2019
e1fdcb4
First fixes for the tinymce builder
bembelimen Mar 9, 2019
ce122a9
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into tinymce-5.0
bembelimen Mar 9, 2019
2101cb8
Remove tabs
bembelimen Mar 9, 2019
a9f3019
Add tinymce builder icons
bembelimen Mar 10, 2019
c7766c9
Clean tabs
bembelimen Mar 10, 2019
fa94a04
Clean up SCSS file for tinymce builder
bembelimen Mar 10, 2019
21b4df9
First version of dragula implementation for the tinymce builder
bembelimen Mar 14, 2019
be2085c
CS whitespaces
bembelimen Mar 14, 2019
b9ffba8
Cleanup
bembelimen Mar 14, 2019
8d3ca85
Fix wrong this context
bembelimen Mar 15, 2019
5bae398
Set the correct context for the main variables
bembelimen Mar 16, 2019
3509b47
Add correct styling to the drag & drop button
bembelimen Mar 16, 2019
7675d80
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into tinymce-5.0
bembelimen Mar 16, 2019
3e46451
Extend fancy select to enable/disable options
bembelimen Mar 16, 2019
32d772a
Implement SVG icons for editor-xtd buttons
bembelimen Mar 17, 2019
47d8ba2
Code cleanup
bembelimen Mar 17, 2019
3903f66
Adjust line length
bembelimen Mar 17, 2019
2d96fbf
Fix button calls
bembelimen Mar 17, 2019
8f9e9f5
Fix line length CS
bembelimen Mar 17, 2019
194a7c8
CS clean up
bembelimen Mar 17, 2019
480b2bb
CS clean up
bembelimen Mar 17, 2019
6486d70
Merge branch '4.0-dev' into fancy-select-option
bembelimen Mar 17, 2019
5831777
Update choices.js
bembelimen Mar 22, 2019
b3bfa55
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into fancy-sel…
bembelimen Mar 22, 2019
a27f61b
Fix choices setting paths
bembelimen Mar 22, 2019
e0a08e1
Add more lock info
bembelimen Mar 23, 2019
c524a79
Add more lock info
bembelimen Mar 23, 2019
8252ab4
Update store loader
bembelimen Mar 23, 2019
ab3f843
Merge branch '4.0-dev' into fancy-select-option
zero-24 Mar 24, 2019
946f874
Update link to the tinymce skin creator
bembelimen Apr 2, 2019
7dd0fde
Merge branch 'tinymce-5.0' of github.com:bembelimen/joomla-cms into t…
bembelimen Apr 11, 2019
c4d0fd6
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into tinymce-5.0
bembelimen Apr 11, 2019
eec6b1e
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into tinymce-5.0
bembelimen Apr 13, 2019
3983980
Update to Choices.js 7.0
bembelimen Apr 13, 2019
54dc2a3
Fix hound issues
bembelimen Apr 13, 2019
beff8fb
More hound fixes
bembelimen Apr 13, 2019
ce79859
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into fancy-sel…
bembelimen Apr 13, 2019
195c6f3
Fix hound issues
bembelimen Apr 13, 2019
dc6ac20
Update package-lock.json
bembelimen Apr 14, 2019
62218d6
Merge branch 'fancy-select-option' into tinymce-5.0
bembelimen Apr 14, 2019
ce19dc3
Disable access level options when already selected.
bembelimen Apr 15, 2019
891dc28
Revert fancy select merge
bembelimen Apr 15, 2019
54ff971
Revert fancy select merge
bembelimen Apr 15, 2019
6e548c0
Fix hound issues
bembelimen Apr 15, 2019
378fe87
Fix broken code
bembelimen Apr 15, 2019
9557273
Fix hound issues
bembelimen Apr 15, 2019
5eea5d7
Fix hound issues
bembelimen Apr 15, 2019
3414eab
Fix hound issues
bembelimen Apr 15, 2019
058168d
Fix hound issues
bembelimen Apr 15, 2019
68e04f6
Fix hound issues
bembelimen Apr 16, 2019
6d5f2b9
Clean up packages
bembelimen Apr 16, 2019
0f86fb9
Clean up packages
bembelimen Apr 16, 2019
07cc7db
Merge branch '4.0-dev' into tinymce-5.0
bembelimen Apr 16, 2019
dadfbf7
Merge branch '4.0-dev' into tinymce-5.0
bembelimen Apr 16, 2019
65b9bce
Fix version string
bembelimen Apr 16, 2019
bf9e962
Merge branch 'tinymce-5.0' of github.com:bembelimen/joomla-cms into t…
bembelimen Apr 16, 2019
632ed26
Hound fix
bembelimen Apr 16, 2019
3a9a848
Merge branch '4.0-dev' into tinymce-5.0
jeckodevelopment Apr 17, 2019
f44f5e0
Set version string hard coded
bembelimen Apr 17, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Fix version string

  • Loading branch information...
bembelimen committed Apr 16, 2019
commit 65b9bce1c10cf17fe4acf3a4270fc4e5e6246f26
@@ -4,7 +4,7 @@ const FsExtra = require('fs-extra');
const Path = require('path');
const RootPath = require('./utils/rootpath.es6.js')._();

const xmlVersionStr = /(<version>)(\d+.\d+.\d+)(<\/version>)/;
const xmlVersionStr = /(<version>)(.+)(<\/version>)/;

This comment has been minimized.

Copy link
@bembelimen

bembelimen Apr 16, 2019

Author Contributor

Reason: versions are not always 3 numbers, could also be less.


/**
* Method that will erase the media/vendor folder
@@ -220,9 +220,11 @@ const copyFiles = (options) => {

copyArrayFiles('', ['tinymce.js', 'tinymce.min.js', 'changelog.txt', 'license.txt'], 'tinymce', '');

let tinyversion = options.dependencies.tinymce.replace(/[^0-9.]/, '');

This comment has been minimized.

Copy link
@hound

hound bot Apr 16, 2019

'tinyversion' is never reassigned. Use 'const' instead prefer-const


// Update the XML file for tinyMCE
let tinyXml = Fs.readFileSync(`${RootPath}/plugins/editors/tinymce/tinymce.xml`, { encoding: 'UTF-8' });
tinyXml = tinyXml.replace(xmlVersionStr, `$1${options.dependencies.tinymce}$3`);
tinyXml = tinyXml.replace(xmlVersionStr, `$1${tinyversion}$3`);
Fs.writeFileSync(`${RootPath}/plugins/editors/tinymce/tinymce.xml`, tinyXml, { encoding: 'UTF-8' });

// Remove that sourcemap...
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<extension version="3.2" type="plugin" group="editors" method="upgrade">
<name>plg_editors_tinymce</name>
<version>~5.0</version>
<version>5.0</version>

This comment has been minimized.

Copy link
@wilsonge

wilsonge Apr 17, 2019

Contributor

This regex still isn't quite working correctly. package-lock.json is showing you have version 5.0.1 so that should be the version in this field

This comment has been minimized.

Copy link
@bembelimen

bembelimen Apr 17, 2019

Author Contributor

I reverted the behavior to "before" and set the version "hard code" into the package.json, so now the coorect version should be displayed.

I'll probably create a new PR to tackle the wrong regexp, but not here...

<creationDate>2005-2017</creationDate>
<author>Ephox Corporation</author>
<authorEmail>N/A</authorEmail>
@@ -24,10 +24,10 @@
<config>
<fields name="params">
<fieldset name="basic">
<field
name="configuration"
type="tinymcebuilder"
hiddenLabel="true"
<field
name="configuration"
type="tinymcebuilder"
hiddenLabel="true"
/>
</fieldset>

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.