Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Wrong language string. Menu item type content/featured #24236

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@ReLater
Copy link
Contributor

ReLater commented Mar 18, 2019

Summary of Changes

  • Exchanged language string for field show_item_navigation

Testing Instructions

Code review (it's obvious) or:

  • Go into a menu item of type Articles » Featured Articles > Tabulator Options
  • Hover the label of Show Navigation to see the description.

Expected result

  • Correct one

Actual result

  • Wrong one
@richard67

This comment has been minimized.

Copy link
Contributor

richard67 commented Mar 18, 2019

I have tested this item successfully on b684b51

Code review. Is indeed obvious.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24236.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Mar 18, 2019

I have tested this item successfully on b684b51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24236.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Mar 18, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24236.

@joomla-cms-bot joomla-cms-bot added the RTC label Mar 18, 2019

@infograf768 infograf768 added this to the Joomla 3.9.5 milestone Mar 19, 2019

@infograf768 infograf768 merged commit a0dabcf into joomla:staging Mar 19, 2019

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Mar 19, 2019

@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Mar 19, 2019

Thanks

@ReLater ReLater deleted the ReLater:patch-7 branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.