Skip to content
This repository

Regression fix: module article news show old news first #2446

Merged
merged 1 commit into from 8 months ago

3 participants

Ofer Cohen David Hurley Dale DeHart
Ofer Cohen

After updating to 3.2.0 module article news show old.
To really fix the issue reported: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28349&start=0

We should add desc/asc ordering in the menu while the current option should stay desc. Do not change the way it's currently work for backward compatibility.

Ofer Cohen oc666 Regression fix: module article news show old news first
After updating to 3.2.0 module article news show old.
To really fix the issue reported: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28349&start=0

We should add desc/asc ordering in the menu while the current option should stay desc. Do not change the way it's currently work for backward compatibility.
6d86a44
David Hurley
Owner

Why was this changed?

Ofer Cohen

Someone thought it's a bug that articles ordering is descending. They need to add option for it in different PR and don't make regression.

David Hurley dbhurley merged commit a07d9b8 into from
Dale DeHart

We have the same issue with the Articles - Newsflash module when Publish Date is selected in the Order Results parameter - we see the oldest article first. So are we saying that ASC (oldest first) is the current (J2.5.16) sorting behaviour? Because that is what we see in our J2.5.16 installations and we're trying to figure out if it is a bug or accurate results. Either way, it is obviously wrong - how can a Newsflash be the oldest news???

Ofer Cohen

@drdehart, this bug was also fixed on 2.5.x branch, so fix will be available on 2.5.17.
Meanwhile, you can change it manually. See the code change in the PR of 2.5.x: #2452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 07, 2013
Ofer Cohen oc666 Regression fix: module article news show old news first
After updating to 3.2.0 module article news show old.
To really fix the issue reported: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28349&start=0

We should add desc/asc ordering in the menu while the current option should stay desc. Do not change the way it's currently work for backward compatibility.
6d86a44
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. +1 1  modules/mod_articles_news/helper.php
2  modules/mod_articles_news/helper.php
@@ -62,7 +62,7 @@ public static function getList(&$params)
62 62 }
63 63 else
64 64 {
65   - $model->setState('list.direction', 'ASC');
  65 + $model->setState('list.direction', 'DESC');
66 66 }
67 67
68 68 // Retrieve Content

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.