Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Changing format handling in Smart Search #24464

Open
wants to merge 2 commits into
base: 4.0-dev
from

Conversation

3 participants
@Hackwar
Copy link
Member

commented Apr 3, 2019

Smart Search has the ability to parse different formats of data, be it HTML, TXT or RTF. And in theory you could extend that to parse also PDFs or DOCX. Unfortunately, right now you are forced to decide which format the whole result item is in for all properties when calling index() in your finder plugin. This prevents us from having results that contain normal HTML and then maybe a file in PDF and another in DOCX format. It is a bit the Highlander issue...

This PR changes that so that you can set the format of the property when telling the indexer how to index that part.

How to test?

In core Joomla, this should not have any impact at all. So simply run the indexer and/or use finder how you did before and you should not notice a difference. I'm asking however for a codereview on this to make sure that my idea is sane. Thus I'm calling for the powers of @chrisdavenport and @wilsonge 馃槈

In another PR, I would also like to add the possibility to point to a file path. If we really want to allow indexing of PDF files for example, we have to change the system a bit to not add the whole file to the result object, too.

@franz-wohlkoenig franz-wohlkoenig added this to In progress in [4.0] Open PRs of Features via automation Apr 4, 2019

@franz-wohlkoenig franz-wohlkoenig added J4 Issue and removed J4 Issue labels Apr 4, 2019

@Hackwar

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

After some more thought, this will need further changes. Please don't merge this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.