[com_fields] - don't traverse the tree

[alikon]

Pull Request for Issue #24361 .

Summary of Changes

we don't need to traverse the tree

Testing Instructions

make a category tree like this
A
-> B
-> -> C
-> -> -> D

create an article field and assign to previous categories (a,b,c,d)
create an article in the D category

visit that artilce you'll see 4 times the same field

see #24361 for more details

Expected result

to see the field once

Actual result

Note

same happens on administrator side if you filter for category before patch

[ghost]

@artur-stepien please test.

[Bakual]

But what happens if you only assign the field to category A? It should imho be available in all subcategories as well (at least code indicates that is intended behavior).
If you change that, it is a change in expected behavior which would be unacceptable in J3.

The thing is, you shouldn't need to assign the field to category B, C and D as they inherit the field from A. So it's kind of a user failure. Neverthlesss it shouldn't show them multiple times, thus a DISTINCT in the query would be the correct solution.

[alikon]

a field should be available in all subcategories .. at least code indicates that is intended behavior

ummm, not so much expected behaviour for me , at least
but i can be wrong

[Bakual]

Afaik it was like this since the feature was introduced.
@laoneo Correct me if i'm wrong.

[alikon]

so let's go with DISTINCT #24516 😄

[laoneo]

@Bakual yes you are right. Both sides have their advantages.