Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] fix field home of #__template_styles table #24595

Merged
merged 17 commits into from Jun 16, 2019

Conversation

Projects
None yet
8 participants
@alikon
Copy link
Contributor

commented Apr 15, 2019

Pull Request for Issue #23188.

Summary of Changes

respect docs & logic
https://docs.joomla.org/Tables/template_styles

alikon added some commits Apr 15, 2019

@alikon alikon changed the title [SQL ] fix field home of #__template_styles table [SQL] fix field home of #__template_styles table Apr 15, 2019

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@GarryMoveOut please test.

Show resolved Hide resolved installation/sql/mysql/joomla.sql Outdated

Quy and others added some commits Apr 16, 2019

Update installation/sql/mysql/joomla.sql
thanks @Quy

Co-Authored-By: alikon <optimus4joomla@gmail.com>
Update administrator/components/com_admin/sql/updates/mysql/3.9.6-201…
…9-04-15.sql


thanks @Quy

Co-Authored-By: alikon <optimus4joomla@gmail.com>
@Quy

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Maybe the following is an issue when using PatchTester.

Run the Database fix the first time:

    Database schema version (3.9.3-2019-02-07) does not match CMS version (3.9.6-2019-04-15).
    Table 'nu7mb_template_styles' should not have index 'idx_home'. (From file 3.9.6-2019-04-15.sql.)
    Table 'nu7mb_template_styles' has the wrong type or attributes for column 'home' with type tinyint(1) unsigned. (From file 3.9.6-2019-04-15.sql.)

Then the result, but idx_home is not created.

Table 'nu7mb_template_styles' does not have index 'idx_home'. (From file 3.9.6-2019-04-15.sql.)

Run the Database fix again, then idx_home is created, however, this message remains:

Table 'nu7mb_template_styles' does not have index 'idx_home'. (From file 3.9.6-2019-04-15.sql.)
Update administrator/components/com_admin/sql/updates/mysql/3.9.6-201…
…9-04-15.sql


thanks @Quy

Co-Authored-By: alikon <optimus4joomla@gmail.com>
@alikon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

ummm maybe splitting the last "CREATE INDEX" in a new file .... i'll give it a try

@twister65

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

I have tested this item successfully on 2572ae5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24595.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

@GarryMoveOut

This comment has been minimized.

Copy link

commented Apr 24, 2019

Sorry for not responding for long time. I didn't have time. I will test soon, maybe this in week.

HLeithner and others added some commits Jun 11, 2019

@Quy

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

I have tested this item successfully on 1116780


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24595.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24595.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 15, 2019

@HLeithner HLeithner merged commit 554d53d into joomla:staging Jun 16, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

thx

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

This PR had errors which are fixed now in PR #25299 . Please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.