Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit frontend article category edit to Publishers and up #24640

Merged
merged 4 commits into from Apr 23, 2019

Conversation

Projects
None yet
7 participants
@infograf768
Copy link
Member

commented Apr 19, 2019

Pull Request for Issue #24626

Summary of Changes

Instead of preventing anyone from modifying the category when editing an already saved article in frontend, this PR allows Publishers and up to do so (edit.state).

Testing Instructions

Create an article as Author in frontend (category can be chosen until article saved).
Publish the article (through backend or frontend)
Log as author and edit the article: the category field is greyed.
Log as Publisher and edit the article: the category field is also greyed.

Patch and retest

After patch

When logging as Publisher, the category field can be modified.

Note

We could also add a new parameter as proposed here:
#24216 (comment)

Which would re-instate as default editing category by Author (edit.own)

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@ThomasK0lasa please test.

@ThomasK0lasa

This comment has been minimized.

Copy link

commented Apr 19, 2019

Works as supposed to. Thank You. :)

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@ThomasK0lasa

This comment has been minimized.

Copy link

commented Apr 19, 2019

I have tested this item successfully on 83d63df

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24640.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@Webdongle please test.

@Webdongle

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

I have tested this item successfully on 0045fc3

Sorry saw the word 'Merged' didn't see it was referring to the other issue. Yes tested OK for me. Thanks for listening.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24640.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@infograf768 can this be RTC or need retest of @ThomasK0lasa ?

@Quy

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24640.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 20, 2019

@HLeithner HLeithner self-assigned this Apr 22, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@ron4mac does this work for you too?

HLeithner and others added some commits Apr 22, 2019

@HLeithner HLeithner merged commit 374ffac into joomla:staging Apr 23, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

thx

@joomla-cms-bot joomla-cms-bot removed the RTC label Apr 23, 2019

@HLeithner HLeithner added this to the Joomla 3.9.6 milestone Apr 23, 2019

@infograf768 infograf768 deleted the infograf768:frontend_category_edit branch Apr 24, 2019

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.