Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banners - fix track date #24652

Merged
merged 3 commits into from Apr 22, 2019
Merged

Banners - fix track date #24652

merged 3 commits into from Apr 22, 2019

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Apr 21, 2019

Pull Request for Issue #24649 .

Summary of Changes

correct timestamp for postgresql

Testing Instructions

see #24649

Expected result

no error on postgresql

Actual result

error on postgresql

@twister65
Copy link
Contributor

@twister65 twister65 commented Apr 21, 2019

@twister65
Copy link
Contributor

@twister65 twister65 commented Apr 21, 2019

In Components->Banners->Tracks, the hour is not localized.
I think, it is another issue.

@alikon
Copy link
Contributor Author

@alikon alikon commented Apr 21, 2019

yes another issue

@ghost ghost changed the title [com_banners] - fix track date Banners - fix track date Apr 21, 2019
@twister65
Copy link
Contributor

@twister65 twister65 commented Apr 21, 2019

I have tested this item successfully on 2ae67e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24652.

@viocassel
Copy link
Contributor

@viocassel viocassel commented Apr 21, 2019

I have tested this item successfully on 2ae67e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24652.

@ghost
Copy link

@ghost ghost commented Apr 21, 2019

Status "Ready To Commit".

@HLeithner HLeithner merged commit cce19e5 into joomla:staging Apr 22, 2019
4 checks passed
@HLeithner
Copy link
Member

@HLeithner HLeithner commented Apr 22, 2019

thx

@HLeithner HLeithner added this to the Joomla 3.9.6 milestone Apr 22, 2019
@alikon alikon deleted the patch-121 branch Apr 22, 2019
@twister65
Copy link
Contributor

@twister65 twister65 commented Apr 22, 2019

Please, see #24651 (comment).
I apologize, I did not pay attention during my test.
See PR #8825 too.

@twister65
Copy link
Contributor

@twister65 twister65 commented Apr 22, 2019

The banners page shows an overview of how many impressions and clicks a banner has received, while the tracks page shows you impression and click data based upon each hour of the day.
See:
#8825 (comment)

@twister65
Copy link
Contributor

@twister65 twister65 commented Apr 30, 2019

This PR should not be merged, it raises a new issue (see #24651 (comment)).
Please, test this PR #24651 instead.

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this issue May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants