Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct SQL error when deleting banner tracks on PostgreSQL databases #24682

Merged
merged 2 commits into from Apr 22, 2019

Conversation

Projects
None yet
4 participants
@richard67
Copy link
Contributor

commented Apr 22, 2019

Pull Request for Issue #24679 .

Summary of Changes

Correct the initial where clause so it resolves to a boolean true on every kind of SQL database before other conditions are concatenated with " AND ...".

Testing Instructions

See issue #24679 + some testers with MySQL database test if things work like before.

Documentation Changes Required

None.

@twister65

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

I have tested this item successfully on 8bdcadb

Successfully tested with PostgreSQL and MySQL databases.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24682.

@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Drone failure not related to this PR. Is caused by javascript stuff.

@zero-24 zero-24 added this to the Joomla 3.9.6 milestone Apr 22, 2019

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Lets see whether drone gets happy now ;)

@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

@zero-24 Can you also set back the result of twister65's test?

@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Now drone succeeded, but Travis failed for reasons not related to this PR.

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

CI is happy now merging on review. Thanks.

@zero-24 zero-24 merged commit 9b03943 into joomla:staging Apr 22, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Thanks.

@richard67 richard67 deleted the richard67:correct-sql-where-1 branch Apr 22, 2019

@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

And thanks to @twister65 who found the mistake.

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.