Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary where clause to avoid SQL error on PostgreSQL databases #24683

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
3 participants
@richard67
Copy link
Contributor

commented Apr 22, 2019

Pull Request for Issue # #24679 (comment) .

Summary of Changes

Remove unnecessary where clause from delete statement when purging finder taxonomy maps to avoid SQL error on PostgreSQL databases.

There is no need for a where clause in that SQL statement, and the existing where clause 1 will cause an error on PostgreSQL databases, see issue #24679 and PR #24682 for another issue caused by the same kind of condition 1 in a where clause.

Testing Instructions

Code review: There is no need for a where clause in that SQL statement.

Documentation Changes Required

None.

@richard67 richard67 changed the title Remove unnecessary where clause from delete statement when purging finder taxonomy maps to avoid SQL error on PostgreSQL databases Remove unnecessary where clause to avoid SQL error on PostgreSQL databases Apr 22, 2019

@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

@twister65 Could you check this one here, too? Is just a code review. Is obvious.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24683.

@zero-24 zero-24 added this to the Joomla 3.9.6 milestone Apr 22, 2019

@zero-24 zero-24 merged commit c532fde into joomla:staging Apr 22, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zero-24

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Merging on review thanks 👍

@richard67

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Thanks.

@richard67 richard67 deleted the richard67:correct-sql-where-2 branch Apr 22, 2019

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.