Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Text align right for select Modules list #24722

Merged
merged 6 commits into from May 8, 2019

Conversation

Projects
None yet
6 participants
@infograf768
Copy link
Member

commented Apr 24, 2019

Summary of Changes

Displaying correctly the list of Modules when selecting a new module.

The existing display code dated back from 2012 when it was necessary to order stuff differently.

Testing Instructions

Install Arabic or Persian language.
Switch to that language in admin
administrator/index.php?option=com_modules&view=select

Before patch

Screen Shot 2019-04-24 at 16 16 17

After patch

Screen Shot 2019-04-24 at 16 02 25

@franz-wohlkoenig franz-wohlkoenig changed the title [staging] RTL Text align right for select Modules list RTL Text align right for select Modules list Apr 24, 2019

infograf768 added some commits Apr 25, 2019

@alikon

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

this pr seem's not present on the issue tracker
Screenshot from 2019-04-27 13-00-19

btw i've tested it successfully

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@infograf768 can you please have a look as PR can't be altered test:
Screen Shot 2019-04-27 at 13 26 21

@alikon

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

some synch glitch happening here now i'm able to see this pr on issue tracker but still unable to mark as tested successfully

@infograf768

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

no idea why it does not sync.

@Quy

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24722.

@joomla-cms-bot joomla-cms-bot added the RTC label May 1, 2019

@SniperSister SniperSister merged commit 9b7ff76 into joomla:staging May 8, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SniperSister

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Thanks, merged!

@joomla-cms-bot joomla-cms-bot removed the RTC label May 8, 2019

@SniperSister SniperSister added this to the Joomla 3.9.7 milestone May 8, 2019

@infograf768 infograf768 deleted the infograf768:rtl_modulelist branch May 8, 2019

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.