Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch copy permission on module #24737

Merged
merged 3 commits into from May 18, 2019

Conversation

Projects
None yet
7 participants
@alikon
Copy link
Contributor

commented Apr 27, 2019

follow up #24730 for module batch copy.

Summary of Changes

let's copy permission too

Testing Instructions

  • Create/edit a module.
  • Go to its permission tab and make a change. (e.g registered->allow creating)
  • Go to Batch and Copy it somewhere else.

Expected result

the permission are copyied too

Actual result

permission are not copied

@richard67

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

I have tested this item successfully on 8f074f3

I've tested with 2 modules which had differenc ACL modifications.
Both modules copied together in 1 batch action.
Before patch: Copied modules have ACL like in new modules.
After patch: Each of the module copies has ACL like the particular copy source module.

Drone error (javascript) seems not to be related to this PR. Code style is ok.

@HLeithner and @wilsonge Release leads please check as also with PR #24730 and PR #24736 if this is a bug fix so it goes into 3.9.next or a new feature for 4.0.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.

@viocassel

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

I have tested this item successfully on 8f074f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 27, 2019

@richard67 richard67 referenced this pull request Apr 27, 2019

Closed

Semver j3 #24728

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

relaunch drone

@richard67

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging).

@infograf768

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Rebased. @HLeithner please decide if merging in 3.9

@HLeithner HLeithner merged commit c8d1f4f into joomla:staging May 18, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 18, 2019

@joomla-cms-bot joomla-cms-bot removed the RTC label May 18, 2019

@alikon alikon deleted the alikon:patch-121 branch May 19, 2019

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.