Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Help Server unofficial property #24927

Merged
merged 7 commits into from Jun 5, 2019

Conversation

Projects
None yet
7 participants
@alikon
Copy link
Contributor

commented May 16, 2019

Pull Request for Issue #22127

Summary of Changes

redo of #22133 - removed Help Server help.joomla.fr cause is unofficial property

Testing Instructions

check help site

Expected result

no more french Help Server

@Quy

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Deprecate JGLOBAL_HELPREFRESH_BUTTON

alikon added some commits May 17, 2019

@alikon

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

done

@Quy

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

I have tested this item successfully on 06181e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24927.

1 similar comment
@viocassel

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

I have tested this item successfully on 06181e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24927.

@joomla-cms-bot joomla-cms-bot changed the title remove Help Server unofficial property remove Help Server unofficial property May 18, 2019

@Quy

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24927.

@joomla-cms-bot joomla-cms-bot added the RTC label May 18, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@alikon Didn't you need to rebuild the css file?

@alikon

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

iirc i've runned genetatecss.php before to sumbit the pr

@HLeithner

This comment has been minimized.

Copy link
Member

commented May 20, 2019

there is no new css file for protostar

@alikon

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

bad memory or bad settings ?
surely both
😄
fixed now
double check please

@alikon alikon referenced this pull request May 22, 2019

Merged

remove the french helpsite #111

@HLeithner HLeithner merged commit f56ea36 into joomla:staging Jun 5, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@HLeithner HLeithner added this to the Joomla 3.9.7 milestone Jun 5, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

thx

@joomla-cms-bot joomla-cms-bot removed the RTC label Jun 5, 2019

@alikon

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

thanks
@HLeithner
don't forget to look at joomla/update.joomla.org#111 too 😃

@alikon alikon deleted the alikon:grr2 branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.