Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add the category first to the ordering when sorting by "ordering" #25295
Summary of Changes
In backend when sorting the articles by "Ordering", it will now first order by the category title and only after that it sorts by ordering.
Items aren't grouped by category.
Items of the same category are right beside them.
Documentation Changes Required
referenced this pull request
Jun 22, 2019
Happy to do so, but it would take me several days or weeks of work to grapple with that as it looks very complex to someone who doesn't use git, has never used Joomla unit tests (or any other type of unit testing) and is a !professional software developer with better things to do than fill my brain up with a load of important stuff that I'll probably never use again.
I got in a right twizzle a few months ago when someone suggested I generate a pull request for a different problem and I then found myself lost in a flood of confusion (for a start it seems to me that a pull is actually a push and vice versa). As a result the fix that I had for some bugs in a JHtml string function have never been implemented as the case was closed. I'm reluctant to mess up this fix likewise...
On the face of it by inspecting the code it looks like it should work. Pretty much the same as my hack solution which works fine on several sites.
PS the bugs in JHtml::_('string.truncate',...) still exist but I have developed a plugin that overrides the duff core function and works fine on my sites so I'm not going to revisit that here - once bitten, twice shy!
I wish there was a way of reporting bugs and fixes in Joomla for people who find them and have identified the problems and have a fix that works but are not able to do the whole git core development thing.
Try with https://docs.joomla.org/Component_Patchtester_for_Testers. That's much simpler and should work for this PR just fine.
Also, for creating a simple PR like this one (and maybe your truncate one), it may be sufficient to use the GitHub WebUI. See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
I agree, Git can be confusing. Especially at the beginning the learning curve is very steep.