Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Fix language strings/unknown columns/sorting #25476

Merged
merged 10 commits into from Jul 11, 2019

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Jul 8, 2019

Summary of Changes

Fix language strings and columns.
Fix Field Group header not sorting.

Testing Instructions

Go to front end.
Edit an article.
Click on the Field button.
Right click on the modal to bring up a contextual menu to open This Frame > Open Frame in New Tab.
View the dropdown in the upper right corner.
Click on the Field Group header.

Go to back end.
Go to Content > Fields
Make sure there are fields assigned to field groups.
Click on Field Group header.
Click on Language header.

@richard67
Copy link
Member

@richard67 richard67 commented Jul 8, 2019

I don't understand test step "Open the frame in a new tab.". You mean the modal for selecting the field? How shall I do that?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.

@Quy
Copy link
Contributor Author

@Quy Quy commented Jul 8, 2019

Updated testing instructions. Thanks.

@richard67
Copy link
Member

@richard67 richard67 commented Jul 8, 2019

I have tested this item successfully on 1f7caf0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jul 9, 2019

Can you also change category_title to g.title to fix this:

Column not found: 1054 Unknown column 'category_title' in 'order clause'

@infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 9, 2019

Can you also change category_title to g.title to fix this:

Looks like we also need to take off category_title from here
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/models/fields.php#L47

@Quy Quy changed the title Use correct language strings Use correct language strings/unknown columns Jul 10, 2019
@Quy Quy changed the title Use correct language strings/unknown columns [com_fields] Fix language strings/unknown columns/sort field group Jul 10, 2019
Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jul 10, 2019

I have tested this item successfully on 4b641aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.

@infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 10, 2019

Found another incongruity in backend Field modal when opening frame in new window. See Language at bottom of dropdown.

Screen Shot 2019-07-10 at 09 17 35

If I modify
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/views/fields/view.html.php#L207 to use a.language
and then in
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/views/fields/tmpl/modal.php#L60
same change.
I do get correctly
Screen Shot 2019-07-10 at 09 45 44

Let's solve also in this PR?

@Quy Quy changed the title [com_fields] Fix language strings/unknown columns/sort field group [com_fields] Fix language strings/unknown columns/sorting Jul 10, 2019
@infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 10, 2019

I have tested this item successfully on e75de2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.

@richard67
Copy link
Member

@richard67 richard67 commented Jul 10, 2019

In the frontext test I see untranslated language strings in the pull down.
I don't think it is related to this PR, but have you both @Quy and @infograf768 applied any other fix which I haven't applied yet? I've fetched clean staging just right now and made a fresh, clean install, and patch I applied with patchtester.

@Quy
Copy link
Contributor Author

@Quy Quy commented Jul 10, 2019

Yes, you also have to install #25475 to fix the untranslated language strings which is not related to this PR.

@richard67
Copy link
Member

@richard67 richard67 commented Jul 10, 2019

I have tested this item successfully on e75de2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.

@Quy
Copy link
Contributor Author

@Quy Quy commented Jul 10, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 10, 2019
@infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 11, 2019

Restarted drone

@infograf768 infograf768 merged commit 3582d28 into staging Jul 11, 2019
8 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC label Jul 11, 2019
@infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 11, 2019

tks

@infograf768 infograf768 added this to the Joomla! 3.9.10 milestone Jul 11, 2019
@infograf768 infograf768 removed this from the Joomla! 3.9.10 milestone Jul 11, 2019
@infograf768 infograf768 added this to the Joomla! 3.9.11 milestone Jul 11, 2019
@Quy Quy deleted the fields-language-strings branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants