Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [plg_system_httpheaders] Drop option "Write headers to the configuration file" #25754

Merged
merged 8 commits into from Sep 13, 2019

Conversation

@zero-24
Copy link
Contributor

commented Jul 31, 2019

Pull Request for Issue #25716

Summary of Changes

As discussed here #25716 this here is removing the htaccess / web.config option from the plugin again for the reasons explained in that issue.

Testing Instructions

Make sure the option is gone and nothing writes to the htaccess and web.config files.
make sure headers are still set correctly.

Expected result

nothing writes to the htaccess and web.config files.

Actual result

this is a option to write to the htaccess and web.config files.

Documentation Changes Required

Yes.

zero-24 added 2 commits Jul 29, 2019
Update plugins/system/httpheaders/httpheaders.php
Co-Authored-By: Quy <quy@fluxbb.org>
zero-24 added 2 commits Aug 5, 2019

@zero-24 zero-24 added this to the Joomla 4.0 milestone Aug 23, 2019

@SharkyKZ

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

I have tested this item successfully on 82630e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25754.

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Thanks for your test @SharkyKZ 👍

zero-24 added 2 commits Sep 3, 2019
@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

As this here in the end removes an feature from the stable build i would like to see it merged before we hit beta.

cc @wilsonge

@wilsonge wilsonge merged commit 1229952 into joomla:4.0-dev Sep 13, 2019

3 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Thanks! Frustrating it didn't work out

@zero-24 zero-24 deleted the zero-24:drop_server_config_files branch Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.