Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct implode() argument order for PHP 7.4 #25784

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@SharkyKZ
Copy link
Contributor

commented Aug 5, 2019

Summary of Changes

Changes implode() argument order to solve deprecation messages in PHP 7.4:

Deprecated: implode(): Passing glue string after array is deprecated.

Testing Instructions

Code review.

Documentation Changes Required

No.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

I have tested this item successfully on a1b3d38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784.

1 similar comment
@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

I have tested this item successfully on a1b3d38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 7, 2019

@HLeithner HLeithner merged commit 8756a48 into joomla:staging Aug 8, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone/pr Build is passing
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 8, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you for the time you invest to make J3 PHP 7.4 compatible.

@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Aug 8, 2019

@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/php74implode branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.