Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct implode() argument order for PHP 7.4 #25784

Merged
merged 1 commit into from Aug 8, 2019
Merged

Correct implode() argument order for PHP 7.4 #25784

merged 1 commit into from Aug 8, 2019

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Aug 5, 2019

Summary of Changes

Changes implode() argument order to solve deprecation messages in PHP 7.4:

Deprecated: implode(): Passing glue string after array is deprecated.

Testing Instructions

Code review.

Documentation Changes Required

No.

@Quy
Copy link
Contributor

@Quy Quy commented Aug 6, 2019

I have tested this item successfully on a1b3d38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784.

1 similar comment
@richard67
Copy link
Member

@richard67 richard67 commented Aug 7, 2019

I have tested this item successfully on a1b3d38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784.

@ghost ghost removed the PR-staging label Aug 7, 2019
@ghost
Copy link

@ghost ghost commented Aug 7, 2019

Status "Ready To Commit".

@ghost ghost added the PR-staging label Aug 7, 2019
@HLeithner HLeithner merged commit 8756a48 into joomla:staging Aug 8, 2019
3 of 5 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 8, 2019
@HLeithner
Copy link
Member

@HLeithner HLeithner commented Aug 8, 2019

Thank you for the time you invest to make J3 PHP 7.4 compatible.

@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Aug 8, 2019
@SharkyKZ SharkyKZ deleted the j3/php74implode branch Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants