Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Tree sorting in templates file tree #25792

Merged
merged 3 commits into from Aug 8, 2019
Merged

Conversation

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Aug 6, 2019

This is a weird one and I cant say I fully understand it but this resolves the problem described below.

If you have a large number of files in a folder then when you look at the list of files in the tree you will see that they are not in alphabetical order. They are in alphabetical order "in groups" which is why you need more than usual files to see it.

To test copy a folder with a lot files to templates\protostar\html

I used this folder as a source administrator\components\com_templates\views\template\tmpl

Now when you view the file tree in the template component you will see the sorting is wrong as per screenshot from the middle of the list
image

Apply this PR and retest and the sorting is as expected as seen in this screenshot from the end of the list

image

This is a weird one and I cant say I fully understand it but this resolves the problem described below.

If you have a large number of files in a folder then when you look at the list of files in the tree you will see that they are not in alphabetical order. They are in alphabetical order "in groups" which is why you need more than usual files to see it.

To test copy a folder with a lot files to `templates\protostar\html`

I used this folder as a source `administrator\components\com_templates\views\template\tmpl`

Now when you view the file tree in the template component you will see the sirting is wrong as per screenshot

Apply this PR and retest and the sirting is as expected.
@brianteeman
Copy link
Member Author

@brianteeman brianteeman commented Aug 6, 2019

NOTE: The same issue exists on J4 but as the fix is identical I assume there is no need for a seperate PR and this will get merged upstream eventually

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Aug 6, 2019

Can you add back weblinks please :P

@brianteeman
Copy link
Member Author

@brianteeman brianteeman commented Aug 6, 2019

Done ;)

@Quy
Copy link
Contributor

@Quy Quy commented Aug 6, 2019

I have tested this item successfully on e7b3b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25792.

1 similar comment
@viocassel
Copy link
Contributor

@viocassel viocassel commented Aug 7, 2019

I have tested this item successfully on e7b3b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25792.

@ghost
Copy link

@ghost ghost commented Aug 7, 2019

Status "Ready To Commit".

@HLeithner HLeithner merged commit 3c678ec into joomla:staging Aug 8, 2019
3 of 5 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 8, 2019
@brianteeman
Copy link
Member Author

@brianteeman brianteeman commented Aug 8, 2019

Thanks - this has been bugging me for ages

@brianteeman brianteeman deleted the sort branch Aug 8, 2019
@HLeithner
Copy link
Member

@HLeithner HLeithner commented Aug 8, 2019

Thank you for the time you invest in Joomla!

@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants