Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Tree sorting in templates file tree #25792

Merged
merged 3 commits into from Aug 8, 2019

Conversation

@brianteeman
Copy link
Contributor

commented Aug 6, 2019

This is a weird one and I cant say I fully understand it but this resolves the problem described below.

If you have a large number of files in a folder then when you look at the list of files in the tree you will see that they are not in alphabetical order. They are in alphabetical order "in groups" which is why you need more than usual files to see it.

To test copy a folder with a lot files to templates\protostar\html

I used this folder as a source administrator\components\com_templates\views\template\tmpl

Now when you view the file tree in the template component you will see the sorting is wrong as per screenshot from the middle of the list
image

Apply this PR and retest and the sorting is as expected as seen in this screenshot from the end of the list

image

Tree sorting in templates file tree
This is a weird one and I cant say I fully understand it but this resolves the problem described below.

If you have a large number of files in a folder then when you look at the list of files in the tree you will see that they are not in alphabetical order. They are in alphabetical order "in groups" which is why you need more than usual files to see it.

To test copy a folder with a lot files to `templates\protostar\html`

I used this folder as a source `administrator\components\com_templates\views\template\tmpl`

Now when you view the file tree in the template component you will see the sirting is wrong as per screenshot

Apply this PR and retest and the sirting is as expected.
@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

NOTE: The same issue exists on J4 but as the fix is identical I assume there is no need for a seperate PR and this will get merged upstream eventually

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Can you add back weblinks please :P

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Done ;)

@Quy

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

I have tested this item successfully on e7b3b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25792.

1 similar comment
@viocassel

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

I have tested this item successfully on e7b3b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25792.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 7, 2019

@HLeithner HLeithner merged commit 3c678ec into joomla:staging Aug 8, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone/pr Build is passing
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 8, 2019

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Thanks - this has been bugging me for ages

@brianteeman brianteeman deleted the brianteeman:sort branch Aug 8, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you for the time you invest in Joomla!

@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.