Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin_actionlogs_joomla] - suppress logout log when user blocked #25812

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@alikon
Copy link
Contributor

commented Aug 11, 2019

Pull Request for Issue #25694 .

Summary of Changes

suppress logout log message when user blocked by anadmin
when a user is blocked from an admin the logout is forced for tecnical reason, so the user itself not have performed the logout action

Testing Instructions

block an user

Expected result

the message logged is only about the "update" action by the admin
Screenshot from 2019-08-11 10-31-35

Actual result

the logged message says that the user is logged out

@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

@alikon What happens if the user is really logged in? Will he/she then be logged out? I think this should be the case.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

I have tested this item successfully on 8d6b263

Without this PR, the user actions log tells that the user was logged out, but this is not really the case. The user is still logged in and can refresh the admin page, and for both, the first user is still shown as being logged in on the logged in users module.

With this PR, the user actions log does not tell this lie anymore that the user has been logged out. The rest of the described behavior remains the same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

@shraddhaSankpal27 Could you test if this pull request (PR) here corrects your issue #25694 ?
Just apply the changes of this PR and test. After test, please mark your test result on the issue tracker here https://issues.joomla.org/tracker/joomla-cms/25812 by using the "Test this" button at the top left corner of that page, then selecting the test result and then submitting.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

I have tested this item successfully on 8d6b263


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

@Quy Quy removed the PR-staging label Aug 12, 2019
@Quy

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 12, 2019
@shraddhaSankpal27

This comment has been minimized.

Copy link

commented Aug 13, 2019

I have tested this item successfully on 8d6b263

@shraddhaSankpal27

This comment has been minimized.

Copy link

commented Aug 13, 2019

I have tested this item successfully on 8d6b263


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

@HLeithner

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Thank you making the action log a bit more correct.

@HLeithner HLeithner merged commit aa666ae into joomla:staging Aug 23, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 23, 2019
@alikon alikon deleted the alikon:patch-112 branch Aug 24, 2019
alikon added a commit to alikon/joomla-cms that referenced this pull request Aug 29, 2019
alikon added a commit to alikon/joomla-cms that referenced this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.