Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plg_system_cache] Disable gzip before caching the page #25823

Merged
merged 3 commits into from Aug 23, 2019

Conversation

@SharkyKZ
Copy link
Contributor

commented Aug 12, 2019

Pull Request for Issue #17501.

Summary of Changes

Makes sure we store uncompressed page in cache.

Testing Instructions

Enable Gzip Compression in Global Configuration.
Enable System - Page Cache plugin.
Open some cacheable frontend page with a form, e.g. username reminder page. Remember its URL.
Start a new session (e.g. clear browser session or use a different browser).
Open the same page and try to submit form.

Expected result

Form submitted.

Actual result

Submitting form fails with warning:

The security token did not match. The request was aborted to prevent any security breach. Please try again.

Documentation Changes Required

No.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Will the page from the cache be served zipped or unzipped?
Update: Looks as if the browser still gets the cached page compressed => good.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

I have tested this item successfully on 6c8c523


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823.

1 similar comment
@viocassel

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

I have tested this item successfully on 6c8c523


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823.

@HLeithner

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Thank you for fixing the cache.

@HLeithner HLeithner merged commit 92aff72 into joomla:staging Aug 23, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 23, 2019
@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/gzipCache branch Aug 23, 2019
alikon added a commit to alikon/joomla-cms that referenced this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.