Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify only unblocked super users #25829

Merged
merged 6 commits into from Aug 19, 2019

Conversation

@eshiol
Copy link
Contributor

commented Aug 13, 2019

Summary of Changes

Fixed Privacy component sends GDPR requests to blocked super users

Testing Instructions

Create a blocked super user
Create a GDPR request

Expected result

The Privacy component sends GDPR requests only to unlocked users

Actual result

Privacy component sends GDPR requests to blocked super users

Documentation Changes Required

@eshiol

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

I propose to send notification only to super users with Receive System Emails = Yes
->where($db->quoteName('sendEmail') . ' = 1')

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@eshiol yes this makes sense please add it to this PR too.

eshiol and others added 3 commits Aug 14, 2019
@zero-24

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

I have tested this item successfully on 5fe0f34

works good to me thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25829.

@viocassel

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

I have tested this item successfully on 5fe0f34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25829.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 19, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Thank you for bringing GDPR requests to the right persons.

@HLeithner HLeithner merged commit fad260c into joomla:staging Aug 19, 2019
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/drone/pr Build is running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 19, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.