Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Google Font weights and styles in Protostar #25976

Merged
merged 2 commits into from Aug 24, 2019

Conversation

@SharkyKZ
Copy link
Contributor

commented Aug 22, 2019

Pull Request for Issue #25972.

Summary of Changes

Add handling for fonts with selected weight and styles.

Testing Instructions

Edit Protostar template style
Enable Google Font for Headings option.
In Google Font Name field enter a font with specific weights/styles, e.g. Open+Sans:400.
Inspect heading fonts in frontend.

Expected result

Headings use selected web font.

Actual result

Headings use standard font.

Documentation Changes Required

No.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

I have tested this item successfully on 06efd35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25976.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

@dioubernard please test (how to: https://docs.joomla.org/Testing_Joomla!_patches)

@richard67

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

I have tested this item successfully on 06efd35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25976.

@franz-wohlkoenig franz-wohlkoenig changed the title Handle Google Font weights and styles in Protostar Handle Google Font weights and styles in Protostar Aug 24, 2019
@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

Status "Ready To Commit".

@HLeithner HLeithner merged commit 81d7fcf into joomla:staging Aug 24, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Aug 24, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

Thanks for creating a better google font integration.

@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 24, 2019
@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/googleFonts branch Aug 24, 2019
alikon added a commit to alikon/joomla-cms that referenced this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.