Fixing broken routing due to missing language parameter. #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32866&start=0 And with the words of Cato the Elder: Ceterum censeo Joomlacode esse delendam (I believe that Joomlacode has to be destroyed. ;-) ) |
mbabker
added a commit
that referenced
this pull request
Dec 6, 2013
Fixing broken routing due to missing language parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a URL to an article is supposed to be generated for another language than the current one, this fails due to Joomla not using the language parameter for ContentHelperRoute::getArticleRoute() right now. This normally rarely happens, since you can only see articles for your current language or for the 'all' language, but when using smart search, you get results for all languages. Due to this bug, the links to non-'all'-language articles are however wrong. This fixes this.
This fix was made possible and is sponsored by Pulsar Informatique: http://www.pulsar-informatique.com/
Thanks for that.