New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken routing due to missing language parameter. #2631

Merged
merged 1 commit into from Dec 6, 2013

Conversation

Projects
None yet
2 participants
@Hackwar
Member

Hackwar commented Dec 2, 2013

When a URL to an article is supposed to be generated for another language than the current one, this fails due to Joomla not using the language parameter for ContentHelperRoute::getArticleRoute() right now. This normally rarely happens, since you can only see articles for your current language or for the 'all' language, but when using smart search, you get results for all languages. Due to this bug, the links to non-'all'-language articles are however wrong. This fixes this.

This fix was made possible and is sponsored by Pulsar Informatique: http://www.pulsar-informatique.com/

Thanks for that.

@Hackwar

This comment has been minimized.

Member

Hackwar commented Dec 2, 2013

Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32866&start=0

And with the words of Cato the Elder: Ceterum censeo Joomlacode esse delendam (I believe that Joomlacode has to be destroyed. ;-) )

mbabker added a commit that referenced this pull request Dec 6, 2013

Merge pull request #2631 from Hackwar/finder_language
Fixing broken routing due to missing language parameter.

@mbabker mbabker merged commit 036de1a into joomla:2.5.x Dec 6, 2013

@Hackwar Hackwar deleted the Hackwar:finder_language branch Dec 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment