Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "active" category detection in mod_articles_categories #26330

Merged
merged 2 commits into from Oct 29, 2019

Conversation

@artur-stepien
Copy link
Contributor

artur-stepien commented Sep 16, 2019

mod_articles_category detects category as active only in category view. Where this should also work for categories view. This fixes the problem.

Pull Request for Issue # .

Summary of Changes

Detect active category also in categories view

Testing Instructions

Create articles categories tree as follows:
A
A -> B
A -> C
A -> C -> D
A -> C -> E

Create new module of type "mod_articles_categories"
Set Parent Category as A
Set Show Subcategories to Yes
As Position set any position that will display the module.
Set the module to display on all pages.
Save the module.
Create a new menu item with Menu Item Type set to List All Categories, then set Select a Top Level Category to C.
Go to front-end
Find the menu item you just created and click it.

Expected result

Category C in mod_articles_categories you created before should have the "active" class on <li> element.

Actual result

C in articles categories module does not have the active class.

Documentation Changes Required

mod_articles_category detects category as active only in category view. Where this should also work for categories view. This fixes the problem.
@artur-stepien artur-stepien changed the title Fixing "active" category detected Fixing "active" category detection in mod_articles_categories Sep 16, 2019
@ladyjer

This comment has been minimized.

Copy link
Contributor

ladyjer commented Oct 19, 2019

I have tested this item successfully on 41eac93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.

@euismod2336

This comment has been minimized.

Copy link
Contributor

euismod2336 commented Oct 19, 2019

I have tested this item successfully on 41eac93

After applying patch, the active class is also set in the categories view


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.

@joomla-cms-bot joomla-cms-bot added the RTC label Oct 19, 2019
@HLeithner HLeithner merged commit d488cb0 into joomla:staging Oct 29, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Oct 29, 2019

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC label Oct 29, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.13 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.