Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Imagelist custom field default image broken #26352

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@infograf768
Copy link
Member

commented Sep 18, 2019

Pull Request for Issue #26350

Redoing #24643 Thanks @ReLater

Summary of Changes

Add a default image in the custom field.
Saves OK now and displays OK in frontend.

Testing Instructions

See #26350 (comment)

Before patch

Screen Shot 2019-09-18 at 10 55 58

After patch

It saves OK and the default image is displayed when editing an article
Screen Shot 2019-09-18 at 11 02 10

and also displays in the article in frontend

Screen Shot 2019-09-18 at 11 39 14

@SharkyKZ @EJBJane
We need this tested fast to get it in 3.9.12

@EJBJane

This comment has been minimized.

Copy link

commented Sep 18, 2019

Patch works for me too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26352.

@HLeithner

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

We have to positive tests, thx to @EJBJane and @infograf768 and @ReLater for testing and fixing this old bug.

@HLeithner HLeithner merged commit 27f1a72 into joomla:staging Sep 18, 2019
4 checks passed
4 checks passed
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Sep 18, 2019
@infograf768 infograf768 deleted the infograf768:imagefieldlistfix branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.