Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress get_magic_quotes_gpc() deprecation notices #26615

Merged
merged 2 commits into from Oct 19, 2019

Conversation

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Oct 17, 2019

Partial Pull Request for Issue #26607.

Summary of Changes

get_magic_quotes_gpc() emits a deprecation notice on PHP 7.4:

Deprecated: Function get_magic_quotes_gpc() is deprecated

This suppresses the notice.

Testing Instructions

Code review.

Documentation Changes Required

No.

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Oct 17, 2019

just remove this function it always returns false since php 5.4

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Oct 17, 2019

ah forget this ;-) j3 please make a php version check suppressing error messages are a bad idea.

@SharkyKZ

This comment has been minimized.

Copy link
Contributor Author

SharkyKZ commented Oct 17, 2019

Added version check.

@euismod2336

This comment has been minimized.

Copy link
Contributor

euismod2336 commented Oct 19, 2019

I have tested this item successfully on 758aa85

## in php >= 5.4 the get_magic_quotes_gpc will no longer be reached


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26615.

@AngermannMarkus

This comment has been minimized.

Copy link

AngermannMarkus commented Oct 19, 2019

I have tested this item successfully on 758aa85

tested with a fresh joomla 3.9.12 with an old php5.6.38, changed all three files without failures.
done a component-joomla update, also without failure.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26615.

@HLeithner HLeithner merged commit e92fd6f into joomla:staging Oct 19, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Oct 19, 2019

thx

@HLeithner HLeithner added this to the Joomla! 3.9.13 milestone Oct 19, 2019
@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/php74/magic branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.