Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla 4.0 updated to PHP 7.2.5 as minimum #27190

Merged
merged 2 commits into from Dec 2, 2019
Merged

Conversation

@zero-24
Copy link
Member

zero-24 commented Dec 1, 2019

Pull Request for Issue https://volunteers.joomla.org/departments/production/reports/1128-production-dept-meeting-november-05-2019

Summary of Changes

As of https://volunteers.joomla.org/departments/production/reports/1128-production-dept-meeting-november-05-2019 the minimum PHP for Joomla 4.0 is 7.2.5

Testing Instructions

Install on php lower than 7.2.5 -> see the message
install on php above 7.2.5 -> (and meet the other requirements) see no message

Expected result

php 7.2.5 is minimum

Actual result

php 7.2.0 is minimum

Documentation Changes Required

none as this is a 4.0 change to be documented with the 4.0 PR that will follow

zero-24 added 2 commits Dec 1, 2019
@zero-24 zero-24 added this to the Joomla! 3.9.14 milestone Dec 1, 2019
@zero-24 zero-24 requested a review from HLeithner Dec 1, 2019
@Quy Quy added the PR-staging label Dec 1, 2019
@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Dec 1, 2019

I have tested this item successfully on 091489b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27190.

@ot2sen

This comment has been minimized.

Copy link
Contributor

ot2sen commented Dec 1, 2019

With Joomla! 4 final release not being released until 2020 we should target a different minimum IMO.
Having a 'security fixes only' minimum from launch do not meet our usual standards of being ahead of the game. At least please make it PHP 7.3+ which has full support throughout 2020.
https://www.php.net/supported-versions.php

@mbabker

This comment has been minimized.

Copy link
Member

mbabker commented Dec 1, 2019

How about don’t bump it again until the beta is tagged as this is now the fourth time it has changed in this iteration of 4.0.

Also, there is zero technical benefit to a 7.3 minimum over 7.2, a 7.3 minimum is purely for the “security support means branch is unsupported” crowd. Personally I would jump 7.2 to 7.4 for minimum but I doubt usage statistics would support that one at this time.

@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Dec 2, 2019

I have tested this item successfully on 091489b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27190.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.14 milestone Dec 2, 2019
@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Dec 2, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27190.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 2, 2019
@wilsonge

This comment has been minimized.

Copy link
Contributor

wilsonge commented Dec 2, 2019

meet our usual standards of being ahead of the game

In the past this wasn't exactly our standard for PHP versions - we deployed based on what was being deployed with linux lts operating systems. Which is the same standard that was used for 7.2.5 if you read the symfony issue tracker on them picking 7.2.5

@wilsonge wilsonge merged commit f679c68 into joomla:staging Dec 2, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wilsonge

This comment has been minimized.

Copy link
Contributor

wilsonge commented Dec 2, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC label Dec 2, 2019
@wilsonge wilsonge added this to the Joomla! 3.9.14 milestone Dec 2, 2019
@zero-24 zero-24 deleted the zero-24:php725 branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.