New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Joomla! extensions update handling of paid for extensions #2769

Merged
merged 6 commits into from Feb 22, 2014

Even simpler, removed unused params

  • Loading branch information...
weeblr committed Jan 6, 2014
commit c69c00bb45d5bccf0aef960dfd2a96ecd74f48e8
@@ -318,7 +318,7 @@ protected function _getPackageFromUrl()
}
// Download the package at the URL given
$p_file = JInstallerHelper::downloadPackage($url, $target = false);
$p_file = JInstallerHelper::downloadPackage($url);
// Was the package downloaded?
if (!$p_file)
@@ -257,7 +257,7 @@ protected function _getPackageUrl( $remote_manifest )
*/
protected function _downloadPackage($url)
{
$p_file = JInstallerHelper::downloadPackage($url, $target = false);
$p_file = JInstallerHelper::downloadPackage($url);
// Was the package downloaded?
if (!$p_file)
@@ -293,7 +293,7 @@ private function install($update)
}
// Load installer plugins for assistance if required:
$p_file = JInstallerHelper::downloadPackage($url, $target = false);
$p_file = JInstallerHelper::downloadPackage($url);
// Was the package downloaded?
if (!$p_file)
@@ -47,10 +47,10 @@ public static function downloadPackage($url, $target = false)
$http = JHttpFactory::getHttp();
// load installer plugins, and allow url and headers modification
$headers = array();
JPluginHelper::importPlugin('installer');
$dispatcher = JEventDispatcher::getInstance();
$headers = array();
$results = $dispatcher->trigger('onInstallerBeforePackageDownload', array($this, &$url, &$headers));
$results = $dispatcher->trigger('onInstallerBeforePackageDownload', array(&$url, &$headers));
$response = $http->get($url, $headers);
ProTip! Use n and p to navigate between commits in a pull request.