New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query-fix in com_content article modal #2795

Merged
merged 8 commits into from Feb 15, 2014

Conversation

Projects
None yet
5 participants
@Hackwar
Member

Hackwar commented Jan 15, 2014

This change prevents the query from being executed when the value is 0. There is never an article with ID 0 and especially when there are more than one modal select per page, you have several unnecessary queries.

Query-fix in com_content article modal
This change prevents the query from being executed when the value is 0. There is never an article with ID 0 and especially when there are more than one modal select per page, you have several unnecessary queries.
@Bakual

This comment has been minimized.

Contributor

Bakual commented Jan 15, 2014

Can you add the tracker and some testing instructions?

@Hackwar

This comment has been minimized.

@Bakual

This comment has been minimized.

Contributor

Bakual commented Feb 7, 2014

especially when there are more than one modal select per page, you have several unnecessary queries.

Do we have this in core somewhere? Just asking for testing. The only place I know we have one modal is the menu item form for the single article view.

catch (RuntimeException $e)
$title = false;
if ((int) $this->value > 0)

This comment has been minimized.

@Bakual

Bakual Feb 7, 2014

Contributor

Do we need a check if ((int) $this->value > 0) here? Imho if ((int) $this->value) would be sufficient.

This comment has been minimized.

@Hackwar

Hackwar Feb 7, 2014

Member

If the value is negative, its equally wrong, but will pass through the if()... Its not strictly necessary, but doesn't hurt either....

This comment has been minimized.

@Bakual

Bakual Feb 7, 2014

Contributor

Is there even a case where it could possibly be a negative? I don't think so.
It's true that it doesn't hurt. It's just not needed.

$db->setQuery(
'SELECT title' .
' FROM #__content' .
' WHERE id = '.(int) $this->value

This comment has been minimized.

@Bakual

Bakual Feb 7, 2014

Contributor

Codestyle: Can you put spaces around the concat? id = ' . (int)

@Hackwar

This comment has been minimized.

Member

Hackwar commented Feb 7, 2014

This is in multilang sites, where you have this field for every language in your site. So a site with 5 languages will have 4 of these fields in every new article.

@Bakual

This comment has been minimized.

Contributor

Bakual commented Feb 7, 2014

This is in multilang sites, where you have this field for every language in your site. So a site with 5 languages will have 4 of these fields in every new article.

Ah thanks!

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 10, 2014

Same should be done for contacts, newsfeeds, categories I guess.

@Hackwar

This comment has been minimized.

Member

Hackwar commented Feb 11, 2014

Better? :-)

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 11, 2014

There is a conflict with the category one

Merge branch 'master' of github.com:Hackwar/joomla-cms into patch-1
Conflicts:
	administrator/components/com_categories/models/fields/modal/category.php
@Hackwar

This comment has been minimized.

Member

Hackwar commented Feb 11, 2014

Should be good now.

JError::raiseWarning(500, $e->getMessage());
$db = JFactory::getDbo();
$db->setQuery(
'SELECT title' .

This comment has been minimized.

@wilsonge

wilsonge Feb 15, 2014

Contributor

Just to be a douchebag can we update these queries to use JDatabaseQuery whilst we're at it? Or would you rather that in a separate PR?

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 15, 2014

@wilsonge
Let's indeed normalise all these queries (not only these) in another PR.

infograf768 added a commit that referenced this pull request Feb 15, 2014

Merge pull request #2795 from Hackwar/patch-1
Query-fix in com_content article modal

@infograf768 infograf768 merged commit 4219e4d into joomla:staging Feb 15, 2014

1 check passed

default The Travis CI build passed
Details

Bakual added a commit to Bakual/joomla-cms that referenced this pull request May 12, 2014

Merge pull request joomla#2795 from Hackwar/patch-1
Query-fix in com_content article modal

@Hackwar Hackwar deleted the Hackwar:patch-1 branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment