Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noopener option to link rel attribute #28005

Merged
merged 1 commit into from Feb 24, 2020
Merged

Conversation

@Quy
Copy link
Contributor

Quy commented Feb 21, 2020

Pull Request for Issue #27990.

Summary of Changes

Add noopener option to link rel attribute of external URL menu type.

Testing Instructions

Add new menu item
Select System Links > URL
Click Link Type tab
Click Link Rel Attribute dropdown
See noopener option

@TVBZ

This comment has been minimized.

Copy link

TVBZ commented Feb 21, 2020

Tested. Working as expected. Thanks!

@SharkyKZ

This comment has been minimized.

Copy link
Contributor

SharkyKZ commented Feb 21, 2020

I have tested this item successfully on 3e3b6ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28005.

@SharkyKZ

This comment has been minimized.

Copy link
Contributor

SharkyKZ commented Feb 21, 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28005.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 21, 2020
@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Feb 22, 2020

I have tested this item successfully on 3e3b6ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28005.

@zero-24 zero-24 merged commit ac9b425 into joomla:staging Feb 24, 2020
5 checks passed
5 checks passed
Hound Smells good to me. Woof!
JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Feb 24, 2020
@zero-24

This comment has been minimized.

Copy link
Member

zero-24 commented Feb 24, 2020

Merging thanks :-)

@zero-24 zero-24 added this to the Joomla! 3.9.16 milestone Feb 24, 2020
@Quy Quy deleted the Quy:27990-noopener branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.