fixes issue with type transformations

[jigius]

Summary of Changes

Since PHP 7.{1-4} server's logs are polluted with notice messages PHP Notice: A non well formed numeric value encountered in %ROOT%/libraries/src/Profiler/Profiler.php on line 126.

The problem is wrong type casting (from string to float).

This patch is resolving this.

Testing Instructions

Looking for mentioned notices into server's logs after any pages have being requested via http proto.

Attention: notice level of messages has to been allowed!

Expected result

Mentioned notices is not found.

Actual result

Mentioned notices is found.

Documentation Changes Required

None

[bonzani]

I have tested this item ✅ successfully on 4f1d9f5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29353.}

[HLeithner]

I moved this to the next version and have an annotation.

With the new code we loose "+" sign for time and memory on output. I would suggest to precompile this values before adding this to the object and in the printf function.

Or evaluate why and if we need this * / 1000 manipulation.

[SharkyKZ]

I would suggest to precompile this values before adding this to the object and in the printf function.

Are you suggesting to change values stored in Joomla\Profiler\Profiler::$marks? I'm hesitant to do this against staging in case anyone actually uses these values as string. On the other hand, this could avoid some problems in existing code when upgrading to PHP 8 (e.g. like we currently have in Debug plugin). In any case we should totally do this at least in 4.0.

I can make the PR, just need to know for which branch.

[SharkyKZ]

Anyways, this PR is fine for now.

[SharkyKZ]

I have tested this item ✅ successfully on 4f1d9f5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29353.}

[SharkyKZ]

RTC.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29353.}

[SharkyKZ]

Actually we could fix this here properly, also without changing data type. @jigius are you still around?

[HLeithner]

@SharkyKZ I mean the text in the $buffer before this PR we had a + (plus) sign if the value is positive, after this change it's missing. but this doesn't touch the $marks array

[SharkyKZ]

This doesn't change buffer output because it's formatted below with sprintf() without plus sign anyways.

Anyways you might want to take a look at #30582 which solves this in a different way, also solving errors on PHP 8.

[HLeithner]

Thanks