Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields missing when editing articles using Beez3 #29577

Merged
merged 2 commits into from Jun 15, 2020
Merged

Custom fields missing when editing articles using Beez3 #29577

merged 2 commits into from Jun 15, 2020

Conversation

SharkyKZ
Copy link
Contributor

Pull Request for Issue #15665.

Summary of Changes

Renders additional fields in article form in frontend.

Testing Instructions

Use Beez3 template in frontend.
Create some article custom fields.
Create/edit an article in frontend.

Expected result

Custom fields shown in form.

Actual result

Custom fields not shown in form.

Documentation Changes Required

No.

@SharkyKZ SharkyKZ changed the title Custom fields missing when editing aritcles using Beez3 Custom fields missing when editing articles using Beez3 Jun 11, 2020
@richard67
Copy link
Member

I have tested this item ✅ successfully on 3a30638

I did not get the notice mentioned in issue #15665 .
But I can confirm that with this PR the fields are shown in frontend editing form of an article when using the Beez3 template, and field validation (e.g. if required and empty) works, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29577.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3a30638


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29577.

@Quy
Copy link
Contributor

Quy commented Jun 12, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29577.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 12, 2020
@wilsonge wilsonge merged commit 8bfa8c2 into joomla:staging Jun 15, 2020
@wilsonge
Copy link
Contributor

Thanks guys!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2020
@wilsonge wilsonge added this to the Joomla! 3.9.20 milestone Jun 15, 2020
@SharkyKZ SharkyKZ deleted the j3/beez3/fields branch June 16, 2020 05:37
Reconix pushed a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants