Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear backend cache when purging the updates #29603

Merged
merged 1 commit into from Jun 15, 2020

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Jun 14, 2020

Summary of Changes

Clear backend cache when purging the updates

Testing Instructions

  • enable caching
  • apply this patch
  • got to com_installer -> updates
  • hit clear cache
  • check the administrator/cache/_system folder creation dates of the files it should be a fresh version.

Expected result

now also the backend caches are cleared

Actual result

right now the backend caches are not cleared.

Documentation Changes Required

none

Mentions

@nikosdion sorry that it took that long to get back to you on this. Please confirm that this is what you had in mind regarding that method. The other two things truncate #__updates and set the last check to zero is already done in the existing code.

@nikosdion
Copy link
Collaborator

nikosdion commented Jun 14, 2020

Yes, that's basically what I found out I had to do every time I was purging existing updates. This also meshes with my experience in previous bug sprints when I had to do the same thing every time a plugin was edited / published / unpublished.

Also: yup, that's one positive test in case it wasn't clear. Sorry, my coffee needs more coffee today...

@richard67
Copy link
Member

richard67 commented Jun 14, 2020

Also: yup, that's one positive test in case it wasn't clear. Sorry, my coffee needs more coffee today...

@nikosdion Does that mean you have tested this PR here with success? If so, could you mark your result in the issue tracker, or shall I do that for you? Or did I get the above wrong and it was not a test of this PR?

@Quy
Copy link
Contributor

Quy commented Jun 14, 2020

I have tested this item successfully on aa3cfe6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29603.

1 similar comment
@richard67
Copy link
Member

richard67 commented Jun 14, 2020

I have tested this item successfully on aa3cfe6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29603.

@richard67
Copy link
Member

richard67 commented Jun 14, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29603.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 14, 2020
@wilsonge wilsonge merged commit 255a41a into joomla:staging Jun 15, 2020
6 checks passed
@wilsonge
Copy link
Contributor

wilsonge commented Jun 15, 2020

Thanks guys!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2020
@wilsonge wilsonge added this to the Joomla! 3.9.20 milestone Jun 15, 2020
Reconix pushed a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants