Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclosed tab set in contact view using Beez3 template

Merged
merged 1 commit into from Jun 21, 2020
Merged

Unclosed tab set in contact view using Beez3 template #29636

merged 1 commit into from Jun 21, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jun 16, 2020

Summary of Changes

Fixes markup.

Testing Instructions

Create a contact.
Set Presentation Style to Tabs.
View the contact in frontend using Beez3 template.

Expected result

No unclosed elements.

Actual result

End tag div seen, but there were open elements.
Unclosed element dl.

Documentation Changes Required

No.

@Quy
Copy link

Quy commented Jun 17, 2020

I have tested this item successfully on cdd7c1c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29636.

1 similar comment
@bonzani
Copy link

bonzani commented Jun 17, 2020

I have tested this item successfully on cdd7c1c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29636.

@Quy Quy removed the PR-staging label Jun 17, 2020
@Quy
Copy link

Quy commented Jun 17, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29636.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 17, 2020
@Quy Quy added the PR-staging label Jun 17, 2020
@wilsonge wilsonge merged commit 777ee14 into joomla:staging Jun 21, 2020
6 checks passed
@wilsonge
Copy link
Contributor

wilsonge commented Jun 21, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC label Jun 21, 2020
@wilsonge wilsonge added this to the Joomla! 3.9.20 milestone Jun 21, 2020
@SharkyKZ SharkyKZ deleted the j3/markup/beez3-contact branch Jun 21, 2020
Reconix pushed a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this issue Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants