[3.x] Update TinyMCE - #30329
Merged
Merged
Conversation
Contributor
Author
|
/cc @joomla/security |
Contributor
|
is the admin-item-edit js supposed to be here? |
Contributor
Author
|
@brianteeman whoops, good catch, fixed |
Contributor
|
I have tested this item ✅ successfully on d98c59e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30329. |
Member
|
I have tested this item ✅ successfully on d98c59e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30329. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30329. |
Contributor
|
Thanks guys! |
Reconix
pushed a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
Upgrade TinyMCE to 4.5.12
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
This reverts commit 792fe8a.
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
This reverts commit 792fe8a.
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
This reverts commit 6426095.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR updates tinymce to version 4.5.12 - this is the highest version we can include in Joomla 3 due to browser support.
It also fixes numerous security issues.
Changelog:
Fixed so links with xlink:href attributes are filtered correctly to prevent XSS. #TINY-1626
Fixed the
selection.setContent()API not running parser filters #TINY-4002Fixed the
visualcharsplugin converting HTML-like text to DOM elements in certain cases #TINY-4507Fixed HTML comments incorrectly being parsed in certain cases #TINY-4511
Fixed a security issue related to CDATA sanitization during parsing #TINY-4669
Fixed content in an iframe element parsing as dom elements instead of text content #TINY-5943