Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate minus sign in Profiler #30582

Merged
merged 1 commit into from Nov 14, 2020
Merged

Remove duplicate minus sign in Profiler #30582

merged 1 commit into from Nov 14, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Sep 6, 2020

Alternative to #29353 and also fixes errors on PHP 8.

Summary of Changes

Removes double minus sign when storing time and memory in Profiler. This fixes type error on PHP 8 and notices on PHP 7.

Testing Instructions

Enable debug on PHP 8.

Actual result BEFORE applying this Pull Request

round(): Argument #1 ($number) must be of type int|float, string given
C:\wamp\www\joomla-cms-3\plugins\system\debug\debug.php:716

Expected result AFTER applying this Pull Request

No errors.

Documentation Changes Required

Don't think so.

@viocassel
Copy link
Contributor

I have tested this item successfully on 24a5e42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30582.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item successfully on 24a5e42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30582.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30582.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 13, 2020
@Quy Quy added the PR-staging label Sep 13, 2020
@HLeithner
Copy link
Member

Waiting to get #29353 merged or rewritten.

@SharkyKZ SharkyKZ added the PHP 8.x PHP 8.x deprecated issues label Oct 7, 2020
@HLeithner HLeithner merged commit cfdb61a into joomla:staging Nov 14, 2020
4 checks passed
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67 richard67 added this to the Joomla! 3.9.23 milestone Nov 14, 2020
@SharkyKZ SharkyKZ deleted the j3/impr/profiler-buffer branch November 14, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants