FoF and PHP 8

[SharkyKZ]

Summary of Changes

Fixes a fatal error, a warning and deprecation notices on PHP 8.

Warning: Private methods cannot be final as they are never overridden by other classes in libraries\fof\controller\controller.php on line 2156
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 89
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 108
Fatal error: Declaration of FOFLayoutHelper::render($layoutFile, $displayData = null, $basePath = '') must be compatible with Joomla\CMS\Layout\LayoutHelper::render($layoutFile, $displayData = null, $basePath = '', $options = null) in libraries\fof\layout\helper.php on line 28
Deprecated: Required parameter $itemName follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $tableClass follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $localKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $remoteKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $ourPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $theirPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $pivotTable follows optional parameter $pivot in libraries\fof\table\relations.php on line 901

Testing Instructions

Documentation Changes Required

Developers who extended FOFLayoutHelper should note they need to add an additional argument to its render() method to support PHP 8.

[zero-24]

FOFLayoutHelper should note they need to add an additional argument to its render() method to support PHP 8.

Is that change also required on php 7 or only on / for php 8?

[SharkyKZ]

PHP 7 only emits a warning.

[zero-24]

👍

[Quy]

I have tested this item ✅ successfully on 0a0a4e7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.}

[Quy]

To reproduce, go to Components > Post-installation Messages.

[jwaisner]

I have tested this item ✅ successfully on 0a0a4e7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.}

[jwaisner]

@SharkyKZ can you restart drone? Looks like it hasn't reported back on this PR.

I don't expect problems as it tested well but want to ensure all checks pass.

[SharkyKZ]

@jwaisner I don't see how to.

[zero-24]

@jwaisner I don't see how to.

Usually you can trigger drone with a new commit or by updating the branch to the latest staging. Can you try whether that works?

[HLeithner]

Seems drone doesn't like the "build message". Please make a new commit

[SharkyKZ]

No dice. It doesn't appear on http://ci.joomla.org/joomla/joomla-cms/.

[HLeithner]

Can you please push again, I removed your emoji from the description...

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.}

[HLeithner]

Thanks