-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
FoF and PHP 8 #30922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FoF and PHP 8 #30922
Conversation
Is that change also required on php 7 or only on / for php 8? |
PHP 7 only emits a warning. |
👍 |
I have tested this item ✅ successfully on 0a0a4e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922. |
To reproduce, go to Components > Post-installation Messages. |
I have tested this item ✅ successfully on 0a0a4e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922. |
@SharkyKZ can you restart drone? Looks like it hasn't reported back on this PR. I don't expect problems as it tested well but want to ensure all checks pass. |
@jwaisner I don't see how to. |
Usually you can trigger drone with a new commit or by updating the branch to the latest staging. Can you try whether that works? |
Seems drone doesn't like the "build message". Please make a new commit |
No dice. It doesn't appear on http://ci.joomla.org/joomla/joomla-cms/. |
Can you please push again, I removed your emoji from the description... |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922. |
Thanks |
Summary of Changes
Fixes a fatal error, a warning and deprecation notices on PHP 8.
Testing Instructions
Documentation Changes Required
Developers who extended
FOFLayoutHelper
should note they need to add an additional argument to itsrender()
method to support PHP 8.