Skip to content

FoF and PHP 8 #30922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 14, 2020
Merged

FoF and PHP 8 #30922

merged 8 commits into from
Nov 14, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Oct 5, 2020

Summary of Changes

Fixes a fatal error, a warning and deprecation notices on PHP 8.

Warning: Private methods cannot be final as they are never overridden by other classes in libraries\fof\controller\controller.php on line 2156
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 89
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 108
Fatal error: Declaration of FOFLayoutHelper::render($layoutFile, $displayData = null, $basePath = '') must be compatible with Joomla\CMS\Layout\LayoutHelper::render($layoutFile, $displayData = null, $basePath = '', $options = null) in libraries\fof\layout\helper.php on line 28
Deprecated: Required parameter $itemName follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $tableClass follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $localKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $remoteKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $ourPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $theirPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $pivotTable follows optional parameter $pivot in libraries\fof\table\relations.php on line 901

Testing Instructions

Documentation Changes Required

Developers who extended FOFLayoutHelper should note they need to add an additional argument to its render() method to support PHP 8.

@zero-24
Copy link
Contributor

zero-24 commented Oct 5, 2020

FOFLayoutHelper should note they need to add an additional argument to its render() method to support PHP 8.

Is that change also required on php 7 or only on / for php 8?

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Oct 5, 2020

PHP 7 only emits a warning.

@zero-24
Copy link
Contributor

zero-24 commented Oct 5, 2020

👍

@SharkyKZ SharkyKZ added the PHP 8.x PHP 8.x deprecated issues label Oct 7, 2020
@zero-24 zero-24 added this to the Joomla! 3.9.23 milestone Oct 28, 2020
@Quy
Copy link
Contributor

Quy commented Oct 31, 2020

I have tested this item ✅ successfully on 0a0a4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.

@Quy
Copy link
Contributor

Quy commented Oct 31, 2020

To reproduce, go to Components > Post-installation Messages.

@jwaisner
Copy link
Member

jwaisner commented Nov 2, 2020

I have tested this item ✅ successfully on 0a0a4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.

@jwaisner
Copy link
Member

jwaisner commented Nov 2, 2020

@SharkyKZ can you restart drone? Looks like it hasn't reported back on this PR.

I don't expect problems as it tested well but want to ensure all checks pass.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Nov 3, 2020

@jwaisner I don't see how to.

@zero-24
Copy link
Contributor

zero-24 commented Nov 3, 2020

@jwaisner I don't see how to.

Usually you can trigger drone with a new commit or by updating the branch to the latest staging. Can you try whether that works?

@HLeithner
Copy link
Member

Seems drone doesn't like the "build message". Please make a new commit

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Nov 3, 2020

No dice. It doesn't appear on http://ci.joomla.org/joomla/joomla-cms/.

@HLeithner
Copy link
Member

Can you please push again, I removed your emoji from the description...

SharkyKZ added 2 commits November 3, 2020 11:25
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.23 milestone Nov 3, 2020
@Quy
Copy link
Contributor

Quy commented Nov 3, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 3, 2020
@HLeithner HLeithner merged commit edba83f into joomla:staging Nov 14, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.23 milestone Nov 14, 2020
@SharkyKZ SharkyKZ deleted the j3/php8/fof branch November 14, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants