Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Added warning note to core.js render messages docblock #31235

Merged
merged 1 commit into from Feb 27, 2021

Conversation

SniperSister
Copy link
Contributor

Summary of Changes

Added a warning note about potential security implications to the core.js Joomla.renderMessages docblock.

Testing Instructions

Core Review

@SniperSister
Copy link
Contributor Author

@dgrammatiko FYI

@SniperSister SniperSister changed the title Added warning note to core.js render messages docblock [3.x] Added warning note to core.js render messages docblock Oct 25, 2020
@dgrammatiko
Copy link
Contributor

I can refactor the J4 messaging code to eliminate the innerHTML and I'm pretty sure I can do it without breaking b/c in the PHP side but the JS endpoint, Joomla.renderMessages() will not be backwards compatible 🤷‍♂️

@HLeithner HLeithner merged commit f97f286 into joomla:staging Feb 27, 2021
@HLeithner HLeithner added this to the Joomla! 3.9.25 milestone Feb 27, 2021
@SniperSister SniperSister deleted the 3x-corejsxsshint branch March 3, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants